e: [PATCH V2 net-next] net: hns: Fix to conditionally convey
> RX checksum flag to stack
>
> From: Salil Mehta
> Date: Thu, 1 Dec 2016 12:09:22 +
>
> > But maybe now since we don't have any method to de-multiplex the kind
> of
> > checksum error (cannot depend
e: [PATCH V2 net-next] net: hns: Fix to conditionally convey
> RX checksum flag to stack
>
> From: Salil Mehta
> Date: Thu, 1 Dec 2016 16:59:14 +
>
> > It looks to me the cumbersome check in the PATCH V2 should
> > be retained.
>
> I really want something simpl
From: Salil Mehta
Date: Thu, 1 Dec 2016 16:59:14 +
> It looks to me the cumbersome check in the PATCH V2 should
> be retained.
I really want something simpler with small checks that are
done in logical pieces in a straigtforward progression.
The code in V2 is completely unreadable.
From: Salil Mehta
Date: Thu, 1 Dec 2016 12:09:22 +
> But maybe now since we don't have any method to de-multiplex the kind of
> checksum error (cannot depend upon register) we can have below code
> re-arrangement:
>
> hns_nic_rx_checksum() {
> /* check supported L3 protocol */
>
mehta.salil@gmail.com;
> > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm
> > Subject: Re: [PATCH V2 net-next] net: hns: Fix to conditionally
> convey
> > RX checksum flag to stack
> >
> > From: Salil Mehta
> > Date: Tue, 29 Nov 2016 13:09:45 +
>
e: [PATCH V2 net-next] net: hns: Fix to conditionally convey
> RX checksum flag to stack
>
> From: Salil Mehta
> Date: Tue, 29 Nov 2016 13:09:45 +
>
> > + /* We only support checksum for IPv4,UDP(over IPv4 or IPv6),
> TCP(over
> > +* IPv4 or IPv6)
From: Salil Mehta
Date: Tue, 29 Nov 2016 13:09:45 +
> + /* We only support checksum for IPv4,UDP(over IPv4 or IPv6), TCP(over
> + * IPv4 or IPv6) and SCTP but we support many L3(IPv4, IPv6, MPLS,
> + * PPPoE etc) and L4(TCP, UDP, GRE, SCTP, IGMP, ICMP etc.) protocols.
> + *
This patch introduces the RX checksum function to check the
status of the hardware calculated checksum and its error and
appropriately convey status to the upper stack in skb->ip_summed
field.
We only support checksum for IPv4, UDP(over IPv4 or IPv6),
TCP(over IPv4 or IPv6) and SCTP but we support
8 matches
Mail list logo
