RE: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-28 Thread Salil Mehta
Hi Jakub/David, > From: Jakub Kicinski [mailto:k...@kernel.org] > Sent: Wednesday, May 27, 2020 8:31 PM > To: tanhuazhong > Cc: David Miller ; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; Salil Mehta ; > Zhuangyuzeng (Yisen) ; Linuxarm > Subject: Re: [PATCH V2 ne

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-27 Thread Jakub Kicinski
On Wed, 27 May 2020 10:31:59 +0800 tanhuazhong wrote: > Hi, Jakub & David. > > For patch#1, is it acceptable adding "ethtool --get-priv-flags" > to query the VLAN. If yes, I will send a RFC for it. The recommended way of implementing vfs with advanced vlan configurations is via "switchdev mode" &

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-26 Thread tanhuazhong
On 2020/5/22 17:35, tanhuazhong wrote: On 2020/5/22 5:37, David Miller wrote: From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2] add

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-22 Thread tanhuazhong
On 2020/5/22 5:37, David Miller wrote: From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2] adds support for 'QoS' field to PVID. Change

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-21 Thread David Miller
From: Jakub Kicinski Date: Thu, 21 May 2020 12:17:07 -0700 > On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: >> This patchset adds two new VLAN feature. >> >> [patch 1] adds a new dynamic VLAN mode. >> [patch 2] adds support for 'QoS' field to PVID. >> >> Change log: >> V1->V2: modifies

Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-21 Thread Jakub Kicinski
On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote: > This patchset adds two new VLAN feature. > > [patch 1] adds a new dynamic VLAN mode. > [patch 2] adds support for 'QoS' field to PVID. > > Change log: > V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski. I don't like the

[PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-21 Thread Huazhong Tan
This patchset adds two new VLAN feature. [patch 1] adds a new dynamic VLAN mode. [patch 2] adds support for 'QoS' field to PVID. Change log: V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski. GuoJia Liao (2): net: hns3: adds support for dynamic VLAN mode net: hns3: add sup