Re: [PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port

2019-09-11 Thread tanhuazhong
On 2019/9/11 18:16, Sergei Shtylyov wrote: Hello! On 11.09.2019 5:40, Huazhong Tan wrote: From: Guangbin Huang For hardware doesn't support use specified speed and duplex    Can't pasre that. "For hardware that does not support using", perhaps? Yes, thanks. Will check the grammar mor

Re: [PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port

2019-09-11 Thread Sergei Shtylyov
Hello! On 11.09.2019 5:40, Huazhong Tan wrote: From: Guangbin Huang For hardware doesn't support use specified speed and duplex Can't parse that. "For hardware that does not support using", perhaps? to negotiate, it's unnecessary to check and modify the port speed and duplex for fibre

Re: [PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port

2019-09-11 Thread Sergei Shtylyov
Hello! On 11.09.2019 5:40, Huazhong Tan wrote: From: Guangbin Huang For hardware doesn't support use specified speed and duplex Can't pasre that. "For hardware that does not support using", perhaps? to negotiate, it's unnecessary to check and modify the port speed and duplex for fibre

[PATCH V2 net-next 4/7] net: hns3: fix port setting handle for fibre port

2019-09-10 Thread Huazhong Tan
From: Guangbin Huang For hardware doesn't support use specified speed and duplex to negotiate, it's unnecessary to check and modify the port speed and duplex for fibre port when autoneg is on. Fixes: 22f48e24a23d ("net: hns3: add autoneg and change speed support for fibre port") Signed-off-by: