Re: [PATCH V3] ACPI / GED: unregister interrupts during shutdown

2017-12-09 Thread Rafael J. Wysocki
On Sat, Dec 9, 2017 at 2:54 AM, Sinan Kaya wrote: > On 12/8/2017 8:54 AM, Rafael J. Wysocki wrote: >>> static int ged_remove(struct platform_device *pdev) >>> +{ >>> + struct acpi_ged_device *geddev = platform_get_drvdata(pdev); >>> >>> + ged_cleanup_irq(geddev); >> Do you really need

Re: [PATCH V3] ACPI / GED: unregister interrupts during shutdown

2017-12-08 Thread Sinan Kaya
On 12/8/2017 8:54 AM, Rafael J. Wysocki wrote: >> static int ged_remove(struct platform_device *pdev) >> +{ >> + struct acpi_ged_device *geddev = platform_get_drvdata(pdev); >> >> + ged_cleanup_irq(geddev); > Do you really need this duplication? You may as well call > ged_shutdown() fr

Re: [PATCH V3] ACPI / GED: unregister interrupts during shutdown

2017-12-08 Thread Rafael J. Wysocki
On Fri, Dec 8, 2017 at 5:40 AM, Sinan Kaya wrote: > Some GED interrupts could be pending by the time we are doing a reboot. > > Even though GED driver uses devm_request_irq() to register the interrupt > handler, the handler is not being freed on time during a shutdown since > the driver is missing

[PATCH V3] ACPI / GED: unregister interrupts during shutdown

2017-12-07 Thread Sinan Kaya
Some GED interrupts could be pending by the time we are doing a reboot. Even though GED driver uses devm_request_irq() to register the interrupt handler, the handler is not being freed on time during a shutdown since the driver is missing a shutdown callback. If the ACPI handler is no longer avai