Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-03-10 Thread Adam Ford
On Wed, Mar 10, 2021 at 4:25 PM Abel Vesa wrote: > > On 21-03-03 10:31:19, Abel Vesa wrote: > > On 21-03-02 13:03:04, Adam Ford wrote: > > > On Mon, Feb 15, 2021 at 7:06 AM Abel Vesa wrote: > > > > > > > > On 21-02-13 08:44:28, Adam Ford wrote: > > > > > On Wed, Feb 3, 2021 at 3:22 PM Adam Ford

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-03-10 Thread Abel Vesa
On 21-03-03 10:31:19, Abel Vesa wrote: > On 21-03-02 13:03:04, Adam Ford wrote: > > On Mon, Feb 15, 2021 at 7:06 AM Abel Vesa wrote: > > > > > > On 21-02-13 08:44:28, Adam Ford wrote: > > > > On Wed, Feb 3, 2021 at 3:22 PM Adam Ford wrote: > > > > > > > > > > On Thu, Jan 21, 2021 at 4:24 AM Abel

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-03-05 Thread Ahmad Fatoum
Hello Adam, On 15.01.21 19:29, Adam Ford wrote: > { > +#ifdef CONFIG_OF > if (imx_keep_uart_clocks) { > int i; > > - imx_uart_clocks = clks; > - for (i = 0; imx_uart_clocks[i]; i++) > - clk_prepare_enable(*imx_uart_clocks[i]); > +

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-03-03 Thread Abel Vesa
On 21-03-02 13:03:04, Adam Ford wrote: > On Mon, Feb 15, 2021 at 7:06 AM Abel Vesa wrote: > > > > On 21-02-13 08:44:28, Adam Ford wrote: > > > On Wed, Feb 3, 2021 at 3:22 PM Adam Ford wrote: > > > > > > > > On Thu, Jan 21, 2021 at 4:24 AM Abel Vesa wrote: > > > > > > > > > > On 21-01-21 10:56:17

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-03-02 Thread Adam Ford
On Mon, Feb 15, 2021 at 7:06 AM Abel Vesa wrote: > > On 21-02-13 08:44:28, Adam Ford wrote: > > On Wed, Feb 3, 2021 at 3:22 PM Adam Ford wrote: > > > > > > On Thu, Jan 21, 2021 at 4:24 AM Abel Vesa wrote: > > > > > > > > On 21-01-21 10:56:17, Sascha Hauer wrote: > > > > > On Wed, Jan 20, 2021 at

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-02-15 Thread Abel Vesa
On 21-02-13 08:44:28, Adam Ford wrote: > On Wed, Feb 3, 2021 at 3:22 PM Adam Ford wrote: > > > > On Thu, Jan 21, 2021 at 4:24 AM Abel Vesa wrote: > > > > > > On 21-01-21 10:56:17, Sascha Hauer wrote: > > > > On Wed, Jan 20, 2021 at 06:14:21PM +0200, Abel Vesa wrote: > > > > > On 21-01-20 16:50:01

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-02-13 Thread Adam Ford
On Wed, Feb 3, 2021 at 3:22 PM Adam Ford wrote: > > On Thu, Jan 21, 2021 at 4:24 AM Abel Vesa wrote: > > > > On 21-01-21 10:56:17, Sascha Hauer wrote: > > > On Wed, Jan 20, 2021 at 06:14:21PM +0200, Abel Vesa wrote: > > > > On 21-01-20 16:50:01, Sascha Hauer wrote: > > > > > On Wed, Jan 20, 2021

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-02-03 Thread Adam Ford
On Thu, Jan 21, 2021 at 4:24 AM Abel Vesa wrote: > > On 21-01-21 10:56:17, Sascha Hauer wrote: > > On Wed, Jan 20, 2021 at 06:14:21PM +0200, Abel Vesa wrote: > > > On 21-01-20 16:50:01, Sascha Hauer wrote: > > > > On Wed, Jan 20, 2021 at 05:28:13PM +0200, Abel Vesa wrote: > > > > > On 21-01-20 16:

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-21 Thread Abel Vesa
On 21-01-21 10:56:17, Sascha Hauer wrote: > On Wed, Jan 20, 2021 at 06:14:21PM +0200, Abel Vesa wrote: > > On 21-01-20 16:50:01, Sascha Hauer wrote: > > > On Wed, Jan 20, 2021 at 05:28:13PM +0200, Abel Vesa wrote: > > > > On 21-01-20 16:13:05, Sascha Hauer wrote: > > > > > Hi Abel, > > > > > > > >

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-21 Thread Sascha Hauer
On Wed, Jan 20, 2021 at 06:14:21PM +0200, Abel Vesa wrote: > On 21-01-20 16:50:01, Sascha Hauer wrote: > > On Wed, Jan 20, 2021 at 05:28:13PM +0200, Abel Vesa wrote: > > > On 21-01-20 16:13:05, Sascha Hauer wrote: > > > > Hi Abel, > > > > > > > > On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-20 Thread Abel Vesa
On 21-01-20 16:50:01, Sascha Hauer wrote: > On Wed, Jan 20, 2021 at 05:28:13PM +0200, Abel Vesa wrote: > > On 21-01-20 16:13:05, Sascha Hauer wrote: > > > Hi Abel, > > > > > > On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa wrote: > > > > On 21-01-18 08:00:43, Adam Ford wrote: > > > > > On Mon

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-20 Thread Sascha Hauer
On Wed, Jan 20, 2021 at 05:28:13PM +0200, Abel Vesa wrote: > On 21-01-20 16:13:05, Sascha Hauer wrote: > > Hi Abel, > > > > On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa wrote: > > > On 21-01-18 08:00:43, Adam Ford wrote: > > > > On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa wrote: > > ... >

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-20 Thread Abel Vesa
On 21-01-20 16:13:05, Sascha Hauer wrote: > Hi Abel, > > On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa wrote: > > On 21-01-18 08:00:43, Adam Ford wrote: > > > On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa wrote: ... > > > > > > > > > > > TBH, I'm against the idea of having to call consumer A

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-20 Thread Sascha Hauer
Hi Abel, On Wed, Jan 20, 2021 at 04:44:54PM +0200, Abel Vesa wrote: > On 21-01-18 08:00:43, Adam Ford wrote: > > On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa wrote: > > > > > > On 21-01-15 12:29:08, Adam Ford wrote: > > > > > > ... > > > > > > > diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-20 Thread Abel Vesa
On 21-01-18 08:00:43, Adam Ford wrote: > On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa wrote: > > > > On 21-01-15 12:29:08, Adam Ford wrote: > > > > ... > > > > > diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c > > > index a66cabfbf94f..66192fe0a898 100644 > > > --- a/drivers/cl

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-18 Thread Adam Ford
On Mon, Jan 18, 2021 at 6:52 AM Abel Vesa wrote: > > On 21-01-15 12:29:08, Adam Ford wrote: > > ... > > > diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c > > index a66cabfbf94f..66192fe0a898 100644 > > --- a/drivers/clk/imx/clk-imx25.c > > +++ b/drivers/clk/imx/clk-imx25.c >

Re: [PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-18 Thread Abel Vesa
On 21-01-15 12:29:08, Adam Ford wrote: ... > diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c > index a66cabfbf94f..66192fe0a898 100644 > --- a/drivers/clk/imx/clk-imx25.c > +++ b/drivers/clk/imx/clk-imx25.c > @@ -73,16 +73,6 @@ enum mx25_clks { > > static struct clk *clk

[PATCH V3] clk: imx: Fix reparenting of UARTs not associated with sdout

2021-01-15 Thread Adam Ford
Most if not all i.MX SoC's call a function which enables all UARTS. This is a problem for users who need to re-parent the clock source, because any attempt to change the parent results in an busy error due to the fact that the clocks have been enabled already. clk: failed to reparent uart1 to sy