Re: [PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-20 Thread Daniel Lezcano
On 06/20/2016 07:50 PM, Ray Jui wrote: [ ... ] -CLOCKSOURCE_OF_DECLARE(bcm_kona, "bcm,kona-timer", kona_timer_init); +CLOCKSOURCE_OF_DECLARE_RET(bcm_kona, "bcm,kona-timer", kona_timer_init); Looks good to me! Acked-by: Ray Jui Can you have a quick look at the patch

Re: [PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-20 Thread Daniel Lezcano
On 06/20/2016 07:50 PM, Ray Jui wrote: [ ... ] -CLOCKSOURCE_OF_DECLARE(bcm_kona, "bcm,kona-timer", kona_timer_init); +CLOCKSOURCE_OF_DECLARE_RET(bcm_kona, "bcm,kona-timer", kona_timer_init); Looks good to me! Acked-by: Ray Jui Can you have a quick look at the patch [63/63] for the kona

Re: [PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-20 Thread Ray Jui
Hi Daniel, On 6/20/2016 10:48 AM, Daniel Lezcano wrote: The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller

Re: [PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-20 Thread Ray Jui
Hi Daniel, On 6/20/2016 10:48 AM, Daniel Lezcano wrote: The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller

[PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-20 Thread Daniel Lezcano
The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting

[PATCH V3] clocksource/drivers/bcm_kona: Convert init function to return error

2016-06-20 Thread Daniel Lezcano
The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting