Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code

2020-06-27 Thread Greg KH
On Sat, Jun 27, 2020 at 09:31:27AM +0200, Marion & Christophe JAILLET wrote: > > Le 27/06/2020 à 07:15, Greg KH a écrit : > > On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: > > > --- > > > v2: takes Dan's comment into account and fix another resource leak. > > > v3: merge the

Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code

2020-06-27 Thread Marion & Christophe JAILLET
Le 27/06/2020 à 07:15, Greg KH a écrit : On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: --- v2: takes Dan's comment into account and fix another resource leak. v3: merge the previous 4 patches in a single one to ease review No, 4 small patches are _MUCH_ easier to

Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code

2020-06-26 Thread Greg KH
On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: > --- > v2: takes Dan's comment into account and fix another resource leak. > v3: merge the previous 4 patches in a single one to ease review No, 4 small patches are _MUCH_ easier to review than one larger one that mixes

Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code

2020-06-26 Thread Greg KH
On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote: > Fix several error handling issues: When you have to list a bunch of different things you do in a driver, that's a huge hint this needs to be broken up into multiple patches. Please do that here. thanks, greg k-h

[PATCH V3] firmware: stratix10-svc: Fix some error handling code

2020-06-26 Thread Christophe JAILLET
Fix several error handling issues: - In 'svc_create_memory_pool()' we memremap some memory. This has to be undone in case of error and if the driver is removed. The easiest way to do it is to use 'devm_memremap()'. - 'svc_create_memory_pool()' returns an error pointer on error, not NULL. In