Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-20 Thread David Miller
From: Ethan Zhao Date: Fri, 18 Jul 2014 11:43:29 +0800 > netxen driver has implemented netxen_nic_get_ethtool_stats() interface, > but it doesn't collect stats.rxdropped in driver, so we will get > different rx_dropped statistic information while using ifconfig and ethtool. > this patch fills sta

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-20 Thread Ethan Zhao
-- Forwarded message -- From: Francois Romieu Date: Mon, Jul 21, 2014 at 2:01 AM Subject: Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats() To: Ethan Zhao Cc: Rajesh Borundia , Ethan Zhao , Manish Chopra , Sony Chacko , netdev , linux-kernel

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-20 Thread Francois Romieu
Ethan Zhao : [...] > you leave us without a tool to track the net core part. Would you like to > hack the kernel code and rebuild just for peek the dropping packets ? Search 'dropwatch' on your favorite engine search. [...] > More radically, and maybe you should write patches to fix them to keep

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
hi, Regarding the r8169 chip, there is no other data fields exported to user via ethtool except for those dumped from hardware statistic counters in 8169 driver. But for Intel 82598 NIC and its driver ixgbe, it exports not only those fields dumped from hardware statistic counters, like:

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
> 在 2014年7月20日,上午12:28,Francois Romieu 写道: > > Ethan Zhao : >>> On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu >>> wrote: >>> Ethan Zhao : > [...] >>> I'd rather see ethtool stats provides one of those: >>> 1. hardware stats only >> Sounds very clear, is it done clear, if so we need othe

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Francois Romieu
Ethan Zhao : > On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu wrote: > > Ethan Zhao : [...] > > I'd rather see ethtool stats provides one of those: > > 1. hardware stats only > Sounds very clear, is it done clear, if so we need other tools ? > Then why net core increase dev->dropped like >

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Ethan Zhao
On Sat, Jul 19, 2014 at 6:19 PM, Francois Romieu wrote: > Ethan Zhao : >> ?? 2014??7??192:21??Rajesh Borundia >> ?? > [...] >> > I think ethtool stats are adapter specific. Driver does not maintain >> > rx_dropped stats and we also don't get it from adapter. I am not >> > sure if e

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-19 Thread Francois Romieu
Ethan Zhao : > ?? 2014??7??192:21??Rajesh Borundia > ?? [...] > > I think ethtool stats are adapter specific. Driver does not maintain > > rx_dropped stats and we also don't get it from adapter. I am not > > sure if ethtool stats should match ifconfig stats as ifconfig also > > adds

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-18 Thread Ethan Zhao
Ethan Zhao >> Subject: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool >> get_ethtool_stats() >> >> netxen driver has implemented netxen_nic_get_ethtool_stats() interface, >> but it doesn't collect stats.rxdropped in driver, so we will get diffe

RE: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-18 Thread Rajesh Borundia
> -Original Message- > From: Ethan Zhao [mailto:ethan.z...@oracle.com] > Sent: Friday, July 18, 2014 9:13 AM > To: Manish Chopra; Sony Chacko; Rajesh Borundia; netdev > Cc: linux-kernel; ethan.ker...@gmail.com; Ethan Zhao > Subject: [PATCH V3] netxen: fix ethtool rx_drop

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Varka Bhadram
On 07/18/2014 11:35 AM, Ethan Zhao wrote: On Fri, Jul 18, 2014 at 11:47 AM, Varka Bhadram wrote: On 07/18/2014 09:13 AM, Ethan Zhao wrote: netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we will get different rx_dropp

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Ethan Zhao
On Fri, Jul 18, 2014 at 11:47 AM, Varka Bhadram wrote: > On 07/18/2014 09:13 AM, Ethan Zhao wrote: >> >> netxen driver has implemented netxen_nic_get_ethtool_stats() interface, >> but it doesn't collect stats.rxdropped in driver, so we will get >> different rx_dropped statistic information while u

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Varka Bhadram
On 07/18/2014 09:13 AM, Ethan Zhao wrote: netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we will get different rx_dropped statistic information while using ifconfig and ethtool. this patch fills stats.rxdropped field wi

[PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Ethan Zhao
netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we will get different rx_dropped statistic information while using ifconfig and ethtool. this patch fills stats.rxdropped field with data from net core with dev_get_stats() j