Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Wed, Jan 31, 2018 at 10:15:33AM -0500, Liang, Kan wrote: > > > On 1/31/2018 8:15 AM, Jiri Olsa wrote: > > On Wed, Jan 31, 2018 at 10:15:39AM +0100, Jiri Olsa wrote: > > > On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: > > > > > Still, the part I am missing here, is why asking for

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Wed, Jan 31, 2018 at 10:15:33AM -0500, Liang, Kan wrote: > > > On 1/31/2018 8:15 AM, Jiri Olsa wrote: > > On Wed, Jan 31, 2018 at 10:15:39AM +0100, Jiri Olsa wrote: > > > On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: > > > > > Still, the part I am missing here, is why asking for

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/31/2018 8:15 AM, Jiri Olsa wrote: On Wed, Jan 31, 2018 at 10:15:39AM +0100, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: Still, the part I am missing here, is why asking for PERF_SAMPLE_PERIOD voids large PEBS. I think it was disabled together with

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/31/2018 8:15 AM, Jiri Olsa wrote: On Wed, Jan 31, 2018 at 10:15:39AM +0100, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: Still, the part I am missing here, is why asking for PERF_SAMPLE_PERIOD voids large PEBS. I think it was disabled together with

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Wed, Jan 31, 2018 at 10:15:39AM +0100, Jiri Olsa wrote: > On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: > > > Still, the part I am missing here, is why asking for > > > PERF_SAMPLE_PERIOD voids large PEBS. > > > > I think it was disabled together with frequency mode > > (which we

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Wed, Jan 31, 2018 at 10:15:39AM +0100, Jiri Olsa wrote: > On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: > > > Still, the part I am missing here, is why asking for > > > PERF_SAMPLE_PERIOD voids large PEBS. > > > > I think it was disabled together with frequency mode > > (which we

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: > > Still, the part I am missing here, is why asking for > > PERF_SAMPLE_PERIOD voids large PEBS. > > I think it was disabled together with frequency mode > (which we could support too, but it's a bit more work) > > But yes PERIOD could

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 07:59:41PM -0800, Andi Kleen wrote: > > Still, the part I am missing here, is why asking for > > PERF_SAMPLE_PERIOD voids large PEBS. > > I think it was disabled together with frequency mode > (which we could support too, but it's a bit more work) > > But yes PERIOD could

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

> Still, the part I am missing here, is why asking for > PERF_SAMPLE_PERIOD voids large PEBS. I think it was disabled together with frequency mode (which we could support too, but it's a bit more work) But yes PERIOD could probably be allowed. -Andi

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

> Still, the part I am missing here, is why asking for > PERF_SAMPLE_PERIOD voids large PEBS. I think it was disabled together with frequency mode (which we could support too, but it's a bit more work) But yes PERIOD could probably be allowed. -Andi

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 10:52 AM, Jiri Olsa wrote: > > On Tue, Jan 30, 2018 at 11:48:18AM -0500, Liang, Kan wrote: > > SNIP > > > > > > > > > The events in fixed mode could enable large PEBS. Events in freq mode > > > > should > > > > not enable large PEBS. > > > > I think that

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 10:52 AM, Jiri Olsa wrote: > > On Tue, Jan 30, 2018 at 11:48:18AM -0500, Liang, Kan wrote: > > SNIP > > > > > > > > > The events in fixed mode could enable large PEBS. Events in freq mode > > > > should > > > > not enable large PEBS. > > > > I think that could be a

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 11:48:18AM -0500, Liang, Kan wrote: SNIP > > > > > > The events in fixed mode could enable large PEBS. Events in freq mode > > > should > > > not enable large PEBS. > > > I think that could be a problem if some events try to enable large PEBS, > > > while others not. >

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 11:48:18AM -0500, Liang, Kan wrote: SNIP > > > > > > The events in fixed mode could enable large PEBS. Events in freq mode > > > should > > > not enable large PEBS. > > > I think that could be a problem if some events try to enable large PEBS, > > > while others not. >

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 11:36 AM, Stephane Eranian wrote: On Tue, Jan 30, 2018 at 7:25 AM, Liang, Kan wrote: On 1/30/2018 10:04 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30,

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 11:36 AM, Stephane Eranian wrote: On Tue, Jan 30, 2018 at 7:25 AM, Liang, Kan wrote: On 1/30/2018 10:04 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800,

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 7:25 AM, Liang, Kan wrote: > > > On 1/30/2018 10:04 AM, Jiri Olsa wrote: >> >> On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: >>> >>> >>> >>> On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800,

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 7:25 AM, Liang, Kan wrote: > > > On 1/30/2018 10:04 AM, Jiri Olsa wrote: >> >> On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: >>> >>> >>> >>> On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote:

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 10:04 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: From: Kan

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 10:04 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: From: Kan Liang -- Changes

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: > > > On 1/30/2018 8:39 AM, Jiri Olsa wrote: > > On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: > > > Hi, > > > > > > On Mon, Jan 29, 2018 at 8:29 AM, wrote: > > > > > > > > From: Kan

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 09:59:15AM -0500, Liang, Kan wrote: > > > On 1/30/2018 8:39 AM, Jiri Olsa wrote: > > On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: > > > Hi, > > > > > > On Mon, Jan 29, 2018 at 8:29 AM, wrote: > > > > > > > > From: Kan Liang > > > > > > > > --

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: From: Kan Liang -- Changes since V2: - Refined the changelog - Introduced

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 8:39 AM, Jiri Olsa wrote: On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: From: Kan Liang -- Changes since V2: - Refined the changelog - Introduced specific read function for large PEBS. The previous

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 4:16 AM, Stephane Eranian wrote: Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: From: Kan Liang -- Changes since V2: - Refined the changelog - Introduced specific read function for large PEBS. The previous

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On 1/30/2018 4:16 AM, Stephane Eranian wrote: Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: From: Kan Liang -- Changes since V2: - Refined the changelog - Introduced specific read function for large PEBS. The previous generic PEBS read function is confusing. Disabled PMU

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: > Hi, > > On Mon, Jan 29, 2018 at 8:29 AM, wrote: > > > > From: Kan Liang > > > > -- > > > > Changes since V2: > > - Refined the changelog > > - Introduced specific read

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

On Tue, Jan 30, 2018 at 01:16:39AM -0800, Stephane Eranian wrote: > Hi, > > On Mon, Jan 29, 2018 at 8:29 AM, wrote: > > > > From: Kan Liang > > > > -- > > > > Changes since V2: > > - Refined the changelog > > - Introduced specific read function for large PEBS. > >The previous generic

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: > > From: Kan Liang > > -- > > Changes since V2: > - Refined the changelog > - Introduced specific read function for large PEBS. >The previous generic PEBS read function is confusing. >

Re: [PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

Hi, On Mon, Jan 29, 2018 at 8:29 AM, wrote: > > From: Kan Liang > > -- > > Changes since V2: > - Refined the changelog > - Introduced specific read function for large PEBS. >The previous generic PEBS read function is confusing. >Disabled PMU in pmu::read() path for large PEBS. >

[PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

From: Kan Liang -- Changes since V2: - Refined the changelog - Introduced specific read function for large PEBS. The previous generic PEBS read function is confusing. Disabled PMU in pmu::read() path for large PEBS. Handled the corner case when

[PATCH V3 0/5] bugs fix for large PEBS mmap read and rdpmc read

From: Kan Liang -- Changes since V2: - Refined the changelog - Introduced specific read function for large PEBS. The previous generic PEBS read function is confusing. Disabled PMU in pmu::read() path for large PEBS. Handled the corner case when reload_times == 0. - Modified the