nonical.com; jasow...@redhat.com; t...@linutronix.de;
> jbeul...@suse.com
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
>
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > + new_val = inb(PIC_MASTER_IMR);
> > + if (probe_val != new_v
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> + new_val = inb(PIC_MASTER_IMR);
> + if (probe_val != new_val) {
Nitpick: Linux coding style should have this as:
if (new_val != probe_val)
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
nonical.com; jasow...@redhat.com; t...@linutronix.de;
> jbeul...@suse.com
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
>
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > This patch implements the proposal put forth by H. Peter Anvin
> .
On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> This patch implements the proposal put forth by H. Peter Anvin
> .
>
> In version V1 of the patch, I had cleaned up the code based on comments from
> Peter.
> In version V2 of the patch, I have addressed additional comments from Peter.
> In thi
This patch implements the proposal put forth by H. Peter Anvin
.
In version V1 of the patch, I had cleaned up the code based on comments from
Peter.
In version V2 of the patch, I have addressed additional comments from Peter.
In this version of the patch, I have addressed Jan's comments
(jbeu
5 matches
Mail list logo