Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 25-09-15, 02:17, Rafael J. Wysocki wrote: > Actually, what about adding a local u32 variable, say val, here and doing > > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)_ec->gpe)) > > goto error; > > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, > > -

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > global_lock is defined as an unsigned long and accessing only its lower > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > for big endian 64 bit systems. > > Fix that by making global_lock an u32 instead. > >

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 23-09-15, 07:52, Zheng, Lv wrote: > And IMO, if we really want to change global_lock, we should make it bool here. Yeah, so the second patch in this series is doing just that. Just kept this patch separate to make more sense. Will resend both and keep you in cc. -- viresh -- To unsubscribe

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 23-09-15, 07:52, Zheng, Lv wrote: > And IMO, if we really want to change global_lock, we should make it bool here. Yeah, so the second patch in this series is doing just that. Just kept this patch separate to make more sense. Will resend both and keep you in cc. -- viresh -- To unsubscribe

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > global_lock is defined as an unsigned long and accessing only its lower > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > for big endian 64 bit systems. > > Fix that by making global_lock an u32 instead. > >

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 25-09-15, 02:17, Rafael J. Wysocki wrote: > Actually, what about adding a local u32 variable, say val, here and doing > > > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)_ec->gpe)) > > goto error; > > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, > > -

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Wednesday 23 September 2015 10:57:44 Sudeep Holla wrote: > > Also I am not against the $subject patch as such, just added > clarification so that it shouldn't be assumed that BE + ACPI works on > ARM64. > Ok, at least we can safely assume that we do not need to backport that patch to stable

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 23/09/15 10:39, Arnd Bergmann wrote: On Wednesday 23 September 2015 10:15:42 Sudeep Holla wrote: On 15/09/15 09:34, Viresh Kumar wrote: global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Wednesday 23 September 2015 10:15:42 Sudeep Holla wrote: > On 15/09/15 09:34, Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > > for big endian 64 bit systems. > > > > Fix

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 15/09/15 09:34, Viresh Kumar wrote: global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. Fix that by making global_lock an u32 instead. Cc: # v4.1+ Signed-off-by:

RE: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

Hi, > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Wednesday, September 16, 2015 9:57 AM > > On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Wednesday 23 September 2015 10:57:44 Sudeep Holla wrote: > > Also I am not against the $subject patch as such, just added > clarification so that it shouldn't be assumed that BE + ACPI works on > ARM64. > Ok, at least we can safely assume that we do not need to backport that patch to stable

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 15/09/15 09:34, Viresh Kumar wrote: global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. Fix that by making global_lock an u32 instead. Cc: #

RE: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

Hi, > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Wednesday, September 16, 2015 9:57 AM > > On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Wednesday 23 September 2015 10:15:42 Sudeep Holla wrote: > On 15/09/15 09:34, Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > > for big endian 64 bit systems. > > > > Fix

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 23/09/15 10:39, Arnd Bergmann wrote: On Wednesday 23 September 2015 10:15:42 Sudeep Holla wrote: On 15/09/15 09:34, Viresh Kumar wrote: global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 16-09-15, 04:06, Rafael J. Wysocki wrote: > In any case, please just split the EC-related changes off from your second > patch and send them separately. That !! change isn't required anymore, will be dropping it completely. -- viresh -- To unsubscribe from this list: send the line

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Wednesday, September 16, 2015 03:57:05 AM Rafael J. Wysocki wrote: > On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > > for big

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > global_lock is defined as an unsigned long and accessing only its lower > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > for big endian 64 bit systems. > > Fix that by making global_lock an u32 instead. > >

[PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. Fix that by making global_lock an u32 instead. Cc: # v4.1+ Signed-off-by: Viresh Kumar --- Its marked just for # v4.1+,

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Wednesday, September 16, 2015 03:57:05 AM Rafael J. Wysocki wrote: > On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > > for big

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On Tuesday, September 15, 2015 02:04:58 PM Viresh Kumar wrote: > global_lock is defined as an unsigned long and accessing only its lower > 32 bits from sysfs is incorrect, as we need to consider other 32 bits > for big endian 64 bit systems. > > Fix that by making global_lock an u32 instead. > >

Re: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

On 16-09-15, 04:06, Rafael J. Wysocki wrote: > In any case, please just split the EC-related changes off from your second > patch and send them separately. That !! change isn't required anymore, will be dropping it completely. -- viresh -- To unsubscribe from this list: send the line

[PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'

global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64 bit systems. Fix that by making global_lock an u32 instead. Cc: # v4.1+ Signed-off-by: Viresh Kumar