Re: [PATCH V3 1/2] FS: Add generic data flush to fsync

2014-04-29 Thread Fabian Frederick
On Tue, 29 Apr 2014 18:19:07 +0200 Jan Kara wrote: > On Mon 28-04-14 23:12:39, Fabian Frederick wrote: > > This patch issues a flush in generic_file_fsync. > > (Modern filesystems already do it) > > > > -Behaviour can be reversed using /sys/devices/.../cache_type > > -Filesystems can also call

Re: [PATCH V3 1/2] FS: Add generic data flush to fsync

2014-04-29 Thread Jan Kara
On Mon 28-04-14 23:12:39, Fabian Frederick wrote: > This patch issues a flush in generic_file_fsync. > (Modern filesystems already do it) > > -Behaviour can be reversed using /sys/devices/.../cache_type > -Filesystems can also call __generic_file_fsync with bool flush false The patch looks good.

[PATCH V3 1/2] FS: Add generic data flush to fsync

2014-04-28 Thread Fabian Frederick
This patch issues a flush in generic_file_fsync. (Modern filesystems already do it) -Behaviour can be reversed using /sys/devices/.../cache_type -Filesystems can also call __generic_file_fsync with bool flush false Suggested-by: Jan Kara Suggested-by: Christoph Hellwig Cc: Jan Kara Cc: Christo