Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-08-08 Thread Brian Norris
Hi Huang, For some reason, I just noticed your question here. But I think it's important to answer. On 03/04/2013 12:59 AM, Huang Shijie wrote: 于 2013年03月04日 16:46, Artem Bityutskiy 写道: Thanks, I forgot we have this great table. BTW, please, do not forget to update it with information about

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Brian Norris
On Mon, Mar 4, 2013 at 12:59 AM, Huang Shijie wrote: > 于 2013年03月04日 16:46, Artem Bityutskiy 写道: > >> Thanks, I forgot we have this great table. BTW, please, do not forget to >> update it with information about these 4 chip you are adding, >> irrespective of the solution we end up with. > > I also

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 16:46, Artem Bityutskiy 写道: Thanks, I forgot we have this great table. BTW, please, do not forget to update it with information about these 4 chip you are adding, irrespective of the solution we end up with. I also want to update the table, but i do not know how to do it. thanks H

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 16:37, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: 于 2013年03月04日 15:50, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: The current code uses the @id to store the device id(byte 1). But if we use the 8 bytes id data as t

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Artem Bityutskiy
On Mon, 2013-03-04 at 16:40 +0800, Huang Shijie wrote: > 于 2013年03月04日 16:24, Artem Bityutskiy 写道: > > On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: > >> 于 2013年03月04日 15:50, Artem Bityutskiy 写道: > >>> On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: > The current code uses the

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 16:24, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: 于 2013年03月04日 15:50, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: The current code uses the @id to store the device id(byte 1). But if we use the 8 bytes id data as t

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Artem Bityutskiy
On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: > 于 2013年03月04日 15:50, Artem Bityutskiy 写道: > > On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: > >> The current code uses the @id to store the device id(byte 1). > >> But if we use the 8 bytes id data as the keyword, and expand the @id

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Artem Bityutskiy
On Mon, 2013-03-04 at 16:08 +0800, Huang Shijie wrote: > 于 2013年03月04日 15:50, Artem Bityutskiy 写道: > > On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: > >> The current code uses the @id to store the device id(byte 1). > >> But if we use the 8 bytes id data as the keyword, and expand the @id

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-04 Thread Huang Shijie
于 2013年03月04日 15:50, Artem Bityutskiy 写道: On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: The current code uses the @id to store the device id(byte 1). But if we use the 8 bytes id data as the keyword, and expand the @id field to 8byte array, the device id is the second byte now. All the

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-03 Thread Artem Bityutskiy
On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: > The current code uses the @id to store the device id(byte 1). > But if we use the 8 bytes id data as the keyword, and expand the @id > field to 8byte array, > the device id is the second byte now. All the added zeros are for the I do not t

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-03 Thread Huang Shijie
于 2013年03月02日 22:21, Artem Bityutskiy 写道: On Sat, 2013-02-16 at 11:56 +0800, Huang Shijie wrote: On Tue, Feb 12, 2013 at 11:47 PM, Artem Bityutskiy wrote: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: + {"SmartMedia 256MiB 3,3V", {0, 0x71}, 512, 256, 0x4000 }, + {"Sm

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-03 Thread Huang Shijie
于 2013年03月02日 22:19, Artem Bityutskiy 写道: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data. Take some Toshiba's nand chips for example. I have 4 Toshiba's nand chips in my

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-02 Thread Artem Bityutskiy
On Sat, 2013-02-16 at 11:56 +0800, Huang Shijie wrote: > On Tue, Feb 12, 2013 at 11:47 PM, Artem Bityutskiy > wrote: > > On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: > >> + {"SmartMedia 256MiB 3,3V", {0, 0x71}, 512, 256, 0x4000 }, > >> + {"SmartMedia 256MiB 3,3V ROM",

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-02 Thread Artem Bityutskiy
On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: > As time goes on, we begin to meet the situation that we can not get enough > information from some nand chips's id data. Take some Toshiba's nand chips > for example. I have 4 Toshiba's nand chips in my hand: > TC58NVG2S0F, TC58NVG3S0F,

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-28 Thread Huang Shijie
于 2013年02月12日 23:47, Artem Bityutskiy 写道: On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: + {"SmartMedia 256MiB 3,3V", {0, 0x71}, 512, 256, 0x4000 }, + {"SmartMedia 256MiB 3,3V ROM", {0, 0x5b}, 512, 256, 0x4000, NAND_ROM}, Sorry for a possibly stupid question, but what

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-15 Thread Huang Shijie
On Tue, Feb 12, 2013 at 11:47 PM, Artem Bityutskiy wrote: > On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: >> + {"SmartMedia 256MiB 3,3V", {0, 0x71}, 512, 256, 0x4000 }, >> + {"SmartMedia 256MiB 3,3V ROM", {0, 0x5b}, 512, 256, 0x4000, >> NAND_ROM}, > > Sorry for a possibl

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-12 Thread Artem Bityutskiy
On Mon, 2013-01-28 at 12:57 +0800, Huang Shijie wrote: > + {"SmartMedia 256MiB 3,3V", {0, 0x71}, 512, 256, 0x4000 }, > + {"SmartMedia 256MiB 3,3V ROM", {0, 0x5b}, 512, 256, 0x4000, > NAND_ROM}, Sorry for a possibly stupid question, but what does it buy you adding another "0" to a

[PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-01-27 Thread Huang Shijie
As time goes on, we begin to meet the situation that we can not get enough information from some nand chips's id data. Take some Toshiba's nand chips for example. I have 4 Toshiba's nand chips in my hand: TC58NVG2S0F, TC58NVG3S0F, TC58NVG5D2, TC58NVG6D2 When we read these chips' datasheets