Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 01:56:43AM +0700, Suravee Suthikulpanit wrote: > Ah.. agree then ;) So, I should branch off that tree of yours with the file > already moved. Could you point me to it? Not my tree, tip/master: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git, the master branch.

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Suravee Suthikulpanit
Hi, On 2/11/16 01:51, Borislav Petkov wrote: So, I thought it might be alright to put the perf_event_amd_iommu.h >here. > >Having the information in the file arch/x86/events/amd/iommu.h seems >strange for having to specify ../../arch/x86/events/amd/iommu.h in the >IOMMU driver. > >So, you think

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 01:42:52AM +0700, Suravee Suthikulpanit wrote: > The reason I picked this location to place the header file is because > there is already an existing include/linux/perf/arm_pmu.h file there. I don't think anything arch-specific belongs in generic kernel header paths. >

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Suravee Suthikulpanit
Hi Boris, On 2/10/16 23:41, Borislav Petkov wrote: On Tue, Feb 09, 2016 at 04:53:51PM -0600, Suravee Suthikulpanit wrote: >This patch consolidates "arch/x86/kernel/cpu/perf_event_amd_iommu.h" and >"drivers/iommu/amd_iommu_proto.h", which contain duplicate function >declarations, into

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Borislav Petkov
On Tue, Feb 09, 2016 at 04:53:51PM -0600, Suravee Suthikulpanit wrote: > This patch consolidates "arch/x86/kernel/cpu/perf_event_amd_iommu.h" and > "drivers/iommu/amd_iommu_proto.h", which contain duplicate function > declarations, into "include/linux/perf/perf_event_amd_iommu.h" > > Reviewed-by:

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Borislav Petkov
On Tue, Feb 09, 2016 at 04:53:51PM -0600, Suravee Suthikulpanit wrote: > This patch consolidates "arch/x86/kernel/cpu/perf_event_amd_iommu.h" and > "drivers/iommu/amd_iommu_proto.h", which contain duplicate function > declarations, into "include/linux/perf/perf_event_amd_iommu.h" > > Reviewed-by:

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Suravee Suthikulpanit
Hi Boris, On 2/10/16 23:41, Borislav Petkov wrote: On Tue, Feb 09, 2016 at 04:53:51PM -0600, Suravee Suthikulpanit wrote: >This patch consolidates "arch/x86/kernel/cpu/perf_event_amd_iommu.h" and >"drivers/iommu/amd_iommu_proto.h", which contain duplicate function >declarations, into

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 01:42:52AM +0700, Suravee Suthikulpanit wrote: > The reason I picked this location to place the header file is because > there is already an existing include/linux/perf/arm_pmu.h file there. I don't think anything arch-specific belongs in generic kernel header paths. >

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Borislav Petkov
On Thu, Feb 11, 2016 at 01:56:43AM +0700, Suravee Suthikulpanit wrote: > Ah.. agree then ;) So, I should branch off that tree of yours with the file > already moved. Could you point me to it? Not my tree, tip/master: http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git, the master branch.

Re: [PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-10 Thread Suravee Suthikulpanit
Hi, On 2/11/16 01:51, Borislav Petkov wrote: So, I thought it might be alright to put the perf_event_amd_iommu.h >here. > >Having the information in the file arch/x86/events/amd/iommu.h seems >strange for having to specify ../../arch/x86/events/amd/iommu.h in the >IOMMU driver. > >So, you think

[PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-09 Thread Suravee Suthikulpanit
This patch consolidates "arch/x86/kernel/cpu/perf_event_amd_iommu.h" and "drivers/iommu/amd_iommu_proto.h", which contain duplicate function declarations, into "include/linux/perf/perf_event_amd_iommu.h" Reviewed-by: Joerg Roedel Signed-off-by: Suravee Suthikulpanit ---

[PATCH V3 1/5] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header

2016-02-09 Thread Suravee Suthikulpanit
This patch consolidates "arch/x86/kernel/cpu/perf_event_amd_iommu.h" and "drivers/iommu/amd_iommu_proto.h", which contain duplicate function declarations, into "include/linux/perf/perf_event_amd_iommu.h" Reviewed-by: Joerg Roedel Signed-off-by: Suravee Suthikulpanit