Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-25 Thread Viresh Kumar
On 24 May 2014 18:29, Pavel Machek wrote: > On Fri 2014-05-23 10:03:27, Viresh Kumar wrote: >> On 22 May 2014 20:22, Eduardo Valentin wrote: >> > However, on CPUs that needs thermal managment, it makes sense to have >> > such dependency, from functional perspective. Mainly because scaling >> > fr

Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-24 Thread Pavel Machek
On Fri 2014-05-23 10:03:27, Viresh Kumar wrote: > On 22 May 2014 20:22, Eduardo Valentin wrote: > > However, on CPUs that needs thermal managment, it makes sense to have > > such dependency, from functional perspective. Mainly because scaling > > frequency and voltage up would be allowed only when

Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-23 Thread Viresh Kumar
> On 23-May-2014, at 6:51 pm, Eduardo Valentin wrote: > I agree. We need to have runtime dependency, and that is the major > concern on my behalf. The problem of Kconfig dependency is that it > imposes sequencing only on module loading, not at boot sequencing. > > Another way around is returning

Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-23 Thread Eduardo Valentin
Hi Viresh, On Fri, May 23, 2014 at 10:03:27AM +0530, Viresh Kumar wrote: > On 22 May 2014 20:22, Eduardo Valentin wrote: > > However, on CPUs that needs thermal managment, it makes sense to have > > such dependency, from functional perspective. Mainly because scaling > > frequency and voltage up

Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-22 Thread Viresh Kumar
On 22 May 2014 20:22, Eduardo Valentin wrote: > However, on CPUs that needs thermal managment, it makes sense to have > such dependency, from functional perspective. Mainly because scaling > frequency and voltage up would be allowed only when thermal management > is enabled. AFAIK, dependencies i

Re: [PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-22 Thread Eduardo Valentin
Hello Viresh, On Thu, May 22, 2014 at 11:07:25AM +0530, Viresh Kumar wrote: > cpufreq-cpu0 uses thermal framework to register a cooling device, but doesn't > depend on it as there are dummy calls provided by thermal layer when > CONFIG_THERMAL=n. So, we don't really need to mention thermal as a de

[PATCH V3 1/8] cpufreq: cpufreq-cpu0: remove dependency on thermal

2014-05-21 Thread Viresh Kumar
cpufreq-cpu0 uses thermal framework to register a cooling device, but doesn't depend on it as there are dummy calls provided by thermal layer when CONFIG_THERMAL=n. So, we don't really need to mention thermal as a dependency for cpufreq-cpu0 in Kconfig. Remove it. Signed-off-by: Viresh Kumar ---