Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-26 Thread Kevin Cernekee
On Wed, Nov 26, 2014 at 1:28 PM, Arnd Bergmann wrote: >> For the BMIPS case: >> >> plat_map_dma_mem* and plat_dma_addr_to_phys are just performing >> remapping, so dma-ranges would work. >> >> plat_unmap_dma_mem is used to perform an extra BMIPS-specific >> cacheflush operation. > > Yes, the

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-26 Thread Arnd Bergmann
On Wednesday 26 November 2014 12:45:47 Kevin Cernekee wrote: > On Mon, Nov 24, 2014 at 1:39 PM, Arnd Bergmann wrote: > >> >> +OF_DECLARE_2(irqchip, mips_cpu_intc, "mti,cpu-interrupt-controller", > >> >> + mips_cpu_irq_of_init); > >> > > >> > OF_DECLARE_2 really wasn't meant to be used

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-26 Thread Kevin Cernekee
On Mon, Nov 24, 2014 at 1:39 PM, Arnd Bergmann wrote: >> > As mentioned before, it seems like you are simply defining these all to >> > zero, >> > like most other platforms do too. Why not add this file as >> > arch/mips/include/asm/mach-generic/war.h and delete all identical copies? >> >>

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-26 Thread Kevin Cernekee
On Mon, Nov 24, 2014 at 1:39 PM, Arnd Bergmann a...@arndb.de wrote: As mentioned before, it seems like you are simply defining these all to zero, like most other platforms do too. Why not add this file as arch/mips/include/asm/mach-generic/war.h and delete all identical copies? Likewise

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-26 Thread Arnd Bergmann
On Wednesday 26 November 2014 12:45:47 Kevin Cernekee wrote: On Mon, Nov 24, 2014 at 1:39 PM, Arnd Bergmann a...@arndb.de wrote: +OF_DECLARE_2(irqchip, mips_cpu_intc, mti,cpu-interrupt-controller, + mips_cpu_irq_of_init); OF_DECLARE_2 really wasn't meant to be used directly.

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-26 Thread Kevin Cernekee
On Wed, Nov 26, 2014 at 1:28 PM, Arnd Bergmann a...@arndb.de wrote: For the BMIPS case: plat_map_dma_mem* and plat_dma_addr_to_phys are just performing remapping, so dma-ranges would work. plat_unmap_dma_mem is used to perform an extra BMIPS-specific cacheflush operation. Yes, the

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Arnd Bergmann
On Monday 24 November 2014 13:07:46 Kevin Cernekee wrote: > On Mon, Nov 24, 2014 at 6:00 AM, Arnd Bergmann wrote: > > It mihgt be good to split this into multiple patches > > OK. For V4 I could submit the arch/mips/bmips code changes in one > patch, and then add the DTS files in the next patch?

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Kevin Cernekee
On Mon, Nov 24, 2014 at 6:00 AM, Arnd Bergmann wrote: > It mihgt be good to split this into multiple patches OK. For V4 I could submit the arch/mips/bmips code changes in one patch, and then add the DTS files in the next patch? >> --- /dev/null >> +++ b/arch/mips/bmips/Kconfig >> @@ -0,0 +1,50

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Kevin Cernekee
On Mon, Nov 24, 2014 at 11:29 AM, Andrew Bresticker wrote: >> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c > >> +void __init plat_time_init(void) >> +{ >> + struct device_node *np; >> + u32 freq; >> + >> + np = of_find_node_by_name(NULL, "cpus"); >> + if

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Andrew Bresticker
> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c > +void __init plat_time_init(void) > +{ > + struct device_node *np; > + u32 freq; > + > + np = of_find_node_by_name(NULL, "cpus"); > + if (!np) > + panic("missing 'cpus' DT node"); > + if

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Andrew Bresticker
Hi, On Mon, Nov 24, 2014 at 6:00 AM, Arnd Bergmann wrote: >> --- >> .../devicetree/bindings/mips/brcm/bmips.txt| 8 + >> .../devicetree/bindings/mips/brcm/soc.txt | 12 ++ >> arch/mips/Kbuild.platforms | 1 + >> arch/mips/Kconfig

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Arnd Bergmann
On Sunday 23 November 2014 18:40:46 Kevin Cernekee wrote: > bmips_be_defconfig supports Linux running on the following CM and DSL > SoCs: > > - BCM3384 (BMIPS5000) cable modem application processor, BE, SMP > - BCM3384 (BMIPS4355) cable modem "spare CPU"*, BE > - BCM6328 (BMIPS4355) ADSL chip,

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Arnd Bergmann
On Sunday 23 November 2014 18:40:46 Kevin Cernekee wrote: bmips_be_defconfig supports Linux running on the following CM and DSL SoCs: - BCM3384 (BMIPS5000) cable modem application processor, BE, SMP - BCM3384 (BMIPS4355) cable modem spare CPU*, BE - BCM6328 (BMIPS4355) ADSL chip, BE -

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Andrew Bresticker
Hi, On Mon, Nov 24, 2014 at 6:00 AM, Arnd Bergmann a...@arndb.de wrote: --- .../devicetree/bindings/mips/brcm/bmips.txt| 8 + .../devicetree/bindings/mips/brcm/soc.txt | 12 ++ arch/mips/Kbuild.platforms | 1 + arch/mips/Kconfig

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Andrew Bresticker
diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c +void __init plat_time_init(void) +{ + struct device_node *np; + u32 freq; + + np = of_find_node_by_name(NULL, cpus); + if (!np) + panic(missing 'cpus' DT node); + if

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Kevin Cernekee
On Mon, Nov 24, 2014 at 11:29 AM, Andrew Bresticker abres...@google.com wrote: diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c +void __init plat_time_init(void) +{ + struct device_node *np; + u32 freq; + + np = of_find_node_by_name(NULL, cpus); + if

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Kevin Cernekee
On Mon, Nov 24, 2014 at 6:00 AM, Arnd Bergmann a...@arndb.de wrote: It mihgt be good to split this into multiple patches OK. For V4 I could submit the arch/mips/bmips code changes in one patch, and then add the DTS files in the next patch? --- /dev/null +++ b/arch/mips/bmips/Kconfig @@ -0,0

Re: [PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-24 Thread Arnd Bergmann
On Monday 24 November 2014 13:07:46 Kevin Cernekee wrote: On Mon, Nov 24, 2014 at 6:00 AM, Arnd Bergmann a...@arndb.de wrote: It mihgt be good to split this into multiple patches OK. For V4 I could submit the arch/mips/bmips code changes in one patch, and then add the DTS files in the next

[PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-23 Thread Kevin Cernekee
bmips_be_defconfig supports Linux running on the following CM and DSL SoCs: - BCM3384 (BMIPS5000) cable modem application processor, BE, SMP - BCM3384 (BMIPS4355) cable modem "spare CPU"*, BE - BCM6328 (BMIPS4355) ADSL chip, BE - BCM6368 (BMIPS4350) ADSL chip, BE, SMP *experimental; most

[PATCH V3 11/11] MIPS: Add multiplatform BMIPS target

2014-11-23 Thread Kevin Cernekee
bmips_be_defconfig supports Linux running on the following CM and DSL SoCs: - BCM3384 (BMIPS5000) cable modem application processor, BE, SMP - BCM3384 (BMIPS4355) cable modem spare CPU*, BE - BCM6328 (BMIPS4355) ADSL chip, BE - BCM6368 (BMIPS4350) ADSL chip, BE, SMP *experimental; most