Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-22 Thread Mike Leach
Hi Suzuki, On Thu, 18 Feb 2021 at 15:14, Suzuki K Poulose wrote: > > On 2/18/21 2:30 PM, Mike Leach wrote: > > HI Suzuki, > > > > On Thu, 18 Feb 2021 at 07:50, Suzuki K Poulose > > wrote: > >> > >> Hi Mike > >> > >> On 2/16/21 9:00 AM, Mike Leach wrote: > >>> Hi Anshuman, > >>> > >>> There have

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-18 Thread Suzuki K Poulose
On 2/18/21 2:30 PM, Mike Leach wrote: HI Suzuki, On Thu, 18 Feb 2021 at 07:50, Suzuki K Poulose wrote: Hi Mike On 2/16/21 9:00 AM, Mike Leach wrote: Hi Anshuman, There have been plenty of detailed comments so I will restrict mine to a few general issues:- 1) Currently there appears to be

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-18 Thread Mike Leach
HI Suzuki, On Thu, 18 Feb 2021 at 07:50, Suzuki K Poulose wrote: > > Hi Mike > > On 2/16/21 9:00 AM, Mike Leach wrote: > > Hi Anshuman, > > > > There have been plenty of detailed comments so I will restrict mine to > > a few general issues:- > > > > 1) Currently there appears to be no sysfs suppo

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-18 Thread Suzuki K Poulose
Hi Mike On 2/16/21 9:00 AM, Mike Leach wrote: Hi Anshuman, There have been plenty of detailed comments so I will restrict mine to a few general issues:- 1) Currently there appears to be no sysfs support (I cannot see the MODE_SYSFS constants running alongside the MODE_PERF ones present in the

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-16 Thread Mike Leach
Hi Anshuman, On Tue, 16 Feb 2021 at 09:44, Anshuman Khandual wrote: > > Hello Mike, > > On 2/16/21 2:30 PM, Mike Leach wrote: > > Hi Anshuman, > > > > There have been plenty of detailed comments so I will restrict mine to > > a few general issues:- > > > > 1) Currently there appears to be no sysf

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-16 Thread Anshuman Khandual
Hello Mike, On 2/16/21 2:30 PM, Mike Leach wrote: > Hi Anshuman, > > There have been plenty of detailed comments so I will restrict mine to > a few general issues:- > > 1) Currently there appears to be no sysfs support (I cannot see the > MODE_SYSFS constants running alongside the MODE_PERF ones

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-16 Thread Mike Leach
Hi Anshuman, There have been plenty of detailed comments so I will restrict mine to a few general issues:- 1) Currently there appears to be no sysfs support (I cannot see the MODE_SYSFS constants running alongside the MODE_PERF ones present in the other sink drivers). This is present on all other

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-15 Thread Anshuman Khandual
On 2/13/21 1:56 AM, Mathieu Poirier wrote: > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system registers. The TRBE supports different addressing >> modes including CPU virtual

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-15 Thread Anshuman Khandual
On 2/12/21 10:27 PM, Mathieu Poirier wrote: > [...] > >>> >>> + if (nr_pages < 2) + return NULL; + + buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, trbe_alloc_node(event)); + if (IS_ERR(buf)) + return ERR_PTR(-ENOMEM); + + pglist = kca

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-12 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > accessible via the system registers. The TRBE supports different addressing > modes including CPU virtual address and buffer modes including the circular >

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-12 Thread Mathieu Poirier
On Fri, Feb 12, 2021 at 11:13:01AM +0530, Anshuman Khandual wrote: > > > On 2/11/21 12:30 AM, Mathieu Poirier wrote: > > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > >> accessible via the system

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-12 Thread Mathieu Poirier
[...] > > > > > >> + if (nr_pages < 2) > >> + return NULL; > >> + > >> + buf = kzalloc_node(sizeof(*buf), GFP_KERNEL, trbe_alloc_node(event)); > >> + if (IS_ERR(buf)) > >> + return ERR_PTR(-ENOMEM); > >> + > >> + pglist = kcalloc(nr_pages, sizeof(*pglist), GFP_KERNEL); > >>

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-11 Thread Anshuman Khandual
On 2/11/21 12:30 AM, Mathieu Poirier wrote: > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system registers. The TRBE supports different addressing >> modes including CPU virtu

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-11 Thread Anshuman Khandual
On 2/12/21 12:30 AM, Mathieu Poirier wrote: > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system registers. The TRBE supports different addressing >> modes including CPU virtu

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-11 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > accessible via the system registers. The TRBE supports different addressing > modes including CPU virtual address and buffer modes including the circular >

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-10 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > accessible via the system registers. The TRBE supports different addressing > modes including CPU virtual address and buffer modes including the circular >

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-10 Thread Mathieu Poirier
On Wed, Feb 10, 2021 at 09:42:29AM +0530, Anshuman Khandual wrote: > > > On 2/9/21 11:09 PM, Mathieu Poirier wrote: > > On Fri, Feb 05, 2021 at 10:53:30AM -0700, Mathieu Poirier wrote: > >> On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > >>> Trace Buffer Extension (TRBE) impl

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-09 Thread Anshuman Khandual
On 2/9/21 11:09 PM, Mathieu Poirier wrote: > On Fri, Feb 05, 2021 at 10:53:30AM -0700, Mathieu Poirier wrote: >> On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >>> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >>> accessible via the system registers

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-09 Thread Mathieu Poirier
On Fri, Feb 05, 2021 at 10:53:30AM -0700, Mathieu Poirier wrote: > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > > Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > > accessible via the system registers. The TRBE supports different addressing > > mode

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-07 Thread Anshuman Khandual
On 2/5/21 11:23 PM, Mathieu Poirier wrote: > On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system registers. The TRBE supports different addressing >> modes including CPU virtua

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-05 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 02:25:35PM +0530, Anshuman Khandual wrote: > Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is > accessible via the system registers. The TRBE supports different addressing > modes including CPU virtual address and buffer modes including the circular >

Re: [PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-02-01 Thread Anshuman Khandual
On 1/29/21 3:53 PM, Suzuki K Poulose wrote: > Hi Anshuman > > On 1/27/21 8:55 AM, Anshuman Khandual wrote: >> Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is >> accessible via the system registers. The TRBE supports different addressing >> modes including CPU virtual add

[PATCH V3 11/14] coresight: sink: Add TRBE driver

2021-01-27 Thread Anshuman Khandual
Trace Buffer Extension (TRBE) implements a trace buffer per CPU which is accessible via the system registers. The TRBE supports different addressing modes including CPU virtual address and buffer modes including the circular buffer mode. The TRBE buffer is addressed by a base pointer (TRBBASER_EL1)