Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-19 Thread Jason Wang
On 2021/2/13 4:14 上午, Guenter Roeck wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang Reported-by: Naresh Kamboju I don't really see the point of having to enable VIRTIO_PCI_MODERN because otherwise VIRTIO_PCI no longer works. If VIRTIO_PCI now

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-17 Thread Jason Wang
On 2021/2/10 下午8:35, Michael S. Tsirkin wrote: On Wed, Feb 10, 2021 at 12:44:03PM +0800, Jason Wang wrote: On 2021/2/9 下午10:20, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig |

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-12 Thread Guenter Roeck
On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang > Reported-by: Naresh Kamboju I don't really see the point of having to enable VIRTIO_PCI_MODERN because otherwise VIRTIO_PCI no longer works. If VIRTIO_PCI now requires VIRTIO_PCI_MODERN, maybe it should

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-10 Thread Michael S. Tsirkin
On Wed, Feb 10, 2021 at 12:44:03PM +0800, Jason Wang wrote: > > On 2021/2/9 下午10:20, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: > > > Signed-off-by: Jason Wang > > > --- > > > drivers/virtio/Kconfig | 10 +- > > >

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Jason Wang
On 2021/2/9 下午10:20, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27 +-

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Jason Wang
On 2021/2/9 下午6:15, Naresh Kamboju wrote: Hi Jason, On Mon, 4 Jan 2021 at 12:28, Jason Wang wrote: Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27 +-

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Michael S. Tsirkin
On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang > --- > drivers/virtio/Kconfig | 10 +- > drivers/virtio/Makefile| 1 + > drivers/virtio/virtio_pci_common.h | 27 +- > drivers/virtio/virtio_pci_modern.c | 617

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Naresh Kamboju
Hi Jason, On Mon, 4 Jan 2021 at 12:28, Jason Wang wrote: > > Signed-off-by: Jason Wang > --- > drivers/virtio/Kconfig | 10 +- > drivers/virtio/Makefile| 1 + > drivers/virtio/virtio_pci_common.h | 27 +- > drivers/virtio/virtio_pci_modern.c | 617

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-09 Thread Michael S. Tsirkin
On Tue, Feb 09, 2021 at 11:29:46AM +0800, Jason Wang wrote: > > On 2021/2/8 下午8:04, Michael S. Tsirkin wrote: > > On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote: > > > On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: > > > > On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: >

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-08 Thread Jason Wang
On 2021/2/8 下午8:04, Michael S. Tsirkin wrote: On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote: On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang I don't exactly get why we need to split the modern

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-08 Thread Michael S. Tsirkin
On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote: > > On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: > > > Signed-off-by: Jason Wang > > I don't exactly get why we need to split the modern driver out, > > and it can confuse

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-07 Thread Jason Wang
On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: Signed-off-by: Jason Wang I don't exactly get why we need to split the modern driver out, and it can confuse people who are used to be seeing virtio-pci. The virtio-pci module still

Re: [PATCH V3 16/19] virtio-pci: introduce modern device module

2021-02-05 Thread Michael S. Tsirkin
On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: > Signed-off-by: Jason Wang I don't exactly get why we need to split the modern driver out, and it can confuse people who are used to be seeing virtio-pci. The vdpa thing so far looks like a development tool, why do we care that it

[PATCH V3 16/19] virtio-pci: introduce modern device module

2021-01-03 Thread Jason Wang
Signed-off-by: Jason Wang --- drivers/virtio/Kconfig | 10 +- drivers/virtio/Makefile| 1 + drivers/virtio/virtio_pci_common.h | 27 +- drivers/virtio/virtio_pci_modern.c | 617 - drivers/virtio/virtio_pci_modern_dev.c | 599