Re: [PATCH V3 2/2] perf symbols: debuglink should take symfs option into account

2015-01-30 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 29, 2015 at 03:54:50PM +0900, Namhyung Kim escreveu: > On Wed, Jan 28, 2015 at 08:08:30PM -0800, Victor Kamensky wrote: > > On 28 January 2015 at 17:38, Namhyung Kim wrote: > > > Acked-by: Namhyung Kim > > Thank you for the Acks! Is there any action items on my side? > > Should I rep

Re: [PATCH V3 2/2] perf symbols: debuglink should take symfs option into account

2015-01-28 Thread Namhyung Kim
On Wed, Jan 28, 2015 at 08:08:30PM -0800, Victor Kamensky wrote: > Hi Namhyung, > > On 28 January 2015 at 17:38, Namhyung Kim wrote: > > Hi Victor, > > > > On Mon, Jan 26, 2015 at 10:34:02PM -0800, Victor Kamensky wrote: > >> Currently code that tries to read corresponding debug symbol > >> file

Re: [PATCH V3 2/2] perf symbols: debuglink should take symfs option into account

2015-01-28 Thread Victor Kamensky
Hi Namhyung, On 28 January 2015 at 17:38, Namhyung Kim wrote: > Hi Victor, > > On Mon, Jan 26, 2015 at 10:34:02PM -0800, Victor Kamensky wrote: >> Currently code that tries to read corresponding debug symbol >> file from .gnu_debuglink section (DSO_BINARY_TYPE__DEBUGLINK) >> does not take in acc

Re: [PATCH V3 2/2] perf symbols: debuglink should take symfs option into account

2015-01-28 Thread Namhyung Kim
Hi Victor, On Mon, Jan 26, 2015 at 10:34:02PM -0800, Victor Kamensky wrote: > Currently code that tries to read corresponding debug symbol > file from .gnu_debuglink section (DSO_BINARY_TYPE__DEBUGLINK) > does not take in account symfs option, so filename__read_debuglink > function cannot open ELF

[PATCH V3 2/2] perf symbols: debuglink should take symfs option into account

2015-01-26 Thread Victor Kamensky
Currently code that tries to read corresponding debug symbol file from .gnu_debuglink section (DSO_BINARY_TYPE__DEBUGLINK) does not take in account symfs option, so filename__read_debuglink function cannot open ELF file, if symfs option is used. Fix is to add proper handling of symfs as it is done