Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-09-06 Thread Pratyush Anand
Hi Thomas, On 06/09/2016:11:58:08 AM, Thomas Gleixner wrote: > On Tue, 16 Aug 2016, Pratyush Anand wrote: > > That's a lot of churn to fix that simple problem. The two liner below > should fix that as well, right? Thanks a lot for your reply. Yes, that should fix. I was n't sure if "setting HPE

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-09-06 Thread Thomas Gleixner
On Tue, 16 Aug 2016, Pratyush Anand wrote: That's a lot of churn to fix that simple problem. The two liner below should fix that as well, right? Thanks, tglx diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c index 43745cac0141..cb8dfc3ee012 100644 --- a/drivers/rtc/rtc-cmos.c

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-30 Thread Alexandre Belloni
On 31/08/2016 at 12:56:17 +0800, Dave Young wrote : > Hi, Pratyush, > > I'm not sure who is the maintainer to review and take the patches, > In MATAINERS file, x86 hpet is orphaned. rtc-cmos may go to rtc > maitianer Alessandro Zummo > > Ccing Andrew maybe he can also take the patches for orphane

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-30 Thread Dave Young
Hi, Pratyush, I'm not sure who is the maintainer to review and take the patches, In MATAINERS file, x86 hpet is orphaned. rtc-cmos may go to rtc maitianer Alessandro Zummo Ccing Andrew maybe he can also take the patches for orphaned component. On 08/30/16 at 03:24pm, Pratyush Anand wrote: > Hi D

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-30 Thread Pratyush Anand
Hi Dave, On 30/08/2016:04:22:30 PM, Dave Young wrote: > Hi, Pratyush > > On 08/16/16 at 08:55am, Pratyush Anand wrote: > > We have observed on few x86 machines with rtc-cmos device that > > hpet_rtc_interrupt() is called just after irq registration and before > > cmos_do_probe() could call hpet_r

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-30 Thread Dave Young
On 08/30/16 at 04:38pm, Dave Young wrote: > On 08/30/16 at 04:22pm, Dave Young wrote: > > Hi, Pratyush > > > > On 08/16/16 at 08:55am, Pratyush Anand wrote: > > > We have observed on few x86 machines with rtc-cmos device that > > > hpet_rtc_interrupt() is called just after irq registration and bef

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-30 Thread Dave Young
On 08/30/16 at 04:22pm, Dave Young wrote: > Hi, Pratyush > > On 08/16/16 at 08:55am, Pratyush Anand wrote: > > We have observed on few x86 machines with rtc-cmos device that > > hpet_rtc_interrupt() is called just after irq registration and before > > cmos_do_probe() could call hpet_rtc_timer_init

Re: [PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-30 Thread Dave Young
Hi, Pratyush On 08/16/16 at 08:55am, Pratyush Anand wrote: > We have observed on few x86 machines with rtc-cmos device that > hpet_rtc_interrupt() is called just after irq registration and before > cmos_do_probe() could call hpet_rtc_timer_init(). > > So, neither hpet_default_delta nor hpet_t1_cm

[PATCH V3 2/2] rtc/rtc-cmos: Initialize software counters before irq is registered

2016-08-15 Thread Pratyush Anand
We have observed on few x86 machines with rtc-cmos device that hpet_rtc_interrupt() is called just after irq registration and before cmos_do_probe() could call hpet_rtc_timer_init(). So, neither hpet_default_delta nor hpet_t1_cmp is initialized by the time interrupt is raised in the given situatio