RE: [PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-11 Thread Jay Agarwal
> > I have mentioned it in description as -> "Corrected logic in read/write > config space to display right device number on bus 0" > > > > > Device 0:00.0 is usually the root complex, and device 0:01.0, 0:02.0 > > > etc are the root ports. The change proposed above makes 0:00.0 the > > > first roo

Re: [PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-11 Thread Thierry Reding
On Tue, Jun 11, 2013 at 10:13:38AM +0530, Jay Agarwal wrote: > > * PGP Signed by an unknown key > > > > On Tue, Jun 04, 2013 at 01:17:15PM -0600, Stephen Warren wrote: > > > On 06/04/2013 12:57 PM, Jay Agarwal wrote: > > [...] > > > > struct tegra_pcie_port { > > > > @@ -384,7 +408,7 @@ static in

RE: [PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-10 Thread Jay Agarwal
> * PGP Signed by an unknown key > > On Tue, Jun 04, 2013 at 01:17:15PM -0600, Stephen Warren wrote: > > On 06/04/2013 12:57 PM, Jay Agarwal wrote: > [...] > > > struct tegra_pcie_port { > > > @@ -384,7 +408,7 @@ static int tegra_pcie_read_conf(struct pci_bus > *bus, unsigned int devfn, > > >

Re: [PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-10 Thread Thierry Reding
On Tue, Jun 04, 2013 at 01:17:15PM -0600, Stephen Warren wrote: > On 06/04/2013 12:57 PM, Jay Agarwal wrote: [...] > > struct tegra_pcie_port { > > @@ -384,7 +408,7 @@ static int tegra_pcie_read_conf(struct pci_bus *bus, > > unsigned int devfn, > > struct tegra_pcie_port *port; > >

RE: [PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-05 Thread Jay Agarwal
> > diff --git > > a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt > > b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt > > > +- avdd-supply: Power supply for controller (1.05V) > > > + "cml": The Tegra clock of that name > > Both those changes need to mention tha

Re: [PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-04 Thread Stephen Warren
On 06/04/2013 12:57 PM, Jay Agarwal wrote: > - Enable PCIe root port 2 for Cardhu > - Make private data structure for each SoC > - Add required Tegra30 clocks and regulators > - Add Tegra30 specific code in enable controller > - Corrected logic in read/write config space to > display right device

[PATCH V3 2/4] ARM: tegra: pcie: Add tegra3 support

2013-06-04 Thread Jay Agarwal
- Enable PCIe root port 2 for Cardhu - Make private data structure for each SoC - Add required Tegra30 clocks and regulators - Add Tegra30 specific code in enable controller - Corrected logic in read/write config space to display right device number on bus 0 - Fixed unnecessary freeing of tegra_p