Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-07-20 Thread Zhang, Jonathan Zhixiong
Hi Matt/Borislav, thanks for the discussion. I am sorry that somehow I did not see this message in my inbox. I found it by surprise through an internet search. On Mon, 22 Jun, at 06:11:31AM, Matt Fleming wrote: Right, but see my previous comment about x86 discarding a bunch of attributes for m

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-23 Thread Matt Fleming
On Mon, 22 Jun, at 06:11:31AM, Matt Fleming wrote: > > Right, but see my previous comment about x86 discarding a bunch of > attributes for memory regions because the kernel "knows better". > > And in most places, yes, the kernel really does know better. But this > APEI case is special because irr

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-21 Thread Matt Fleming
On Mon, 15 Jun, at 04:59:08PM, Borislav Petkov wrote: > On Mon, Jun 15, 2015 at 03:15:33PM +0100, Matt Fleming wrote: > > On Sat, 13 Jun, at 10:27:51AM, Borislav Petkov wrote: > > > On Fri, Jun 12, 2015 at 04:44:25PM -0700, Zhang, Jonathan Zhixiong wrote: > > > > Since such function is only needed

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-15 Thread Borislav Petkov
On Mon, Jun 15, 2015 at 03:15:33PM +0100, Matt Fleming wrote: > On Sat, 13 Jun, at 10:27:51AM, Borislav Petkov wrote: > > On Fri, Jun 12, 2015 at 04:44:25PM -0700, Zhang, Jonathan Zhixiong wrote: > > > Since such function is only needed for APEI functionality, at least as > > > of today, I will nam

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-15 Thread Matt Fleming
On Sat, 13 Jun, at 10:27:51AM, Borislav Petkov wrote: > On Fri, Jun 12, 2015 at 04:44:25PM -0700, Zhang, Jonathan Zhixiong wrote: > > Since such function is only needed for APEI functionality, at least as > > of today, I will name it arch_apei_get_mem_attribute(). > > Why? > > It can be extended

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-13 Thread Borislav Petkov
On Fri, Jun 12, 2015 at 04:44:25PM -0700, Zhang, Jonathan Zhixiong wrote: > Since such function is only needed for APEI functionality, at least as > of today, I will name it arch_apei_get_mem_attribute(). Why? It can be extended to be used generically too, no? Come to think of it, the different a

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-12 Thread Zhang, Jonathan Zhixiong
On 6/12/2015 9:29 AM, Borislav Petkov wrote: On Thu, Jun 11, 2015 at 11:26:00AM -0700, Jonathan (Zhixiong) Zhang wrote: From: "Jonathan (Zhixiong) Zhang" With ACPI APEI firmware first handling, generic hardware error record is updated by firmware in GHES memory region. When firmware updated

Re: [PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-12 Thread Borislav Petkov
On Thu, Jun 11, 2015 at 11:26:00AM -0700, Jonathan (Zhixiong) Zhang wrote: > From: "Jonathan (Zhixiong) Zhang" > > With ACPI APEI firmware first handling, generic hardware error > record is updated by firmware in GHES memory region. When firmware > updated GHES memory region with uncached access

[PATCH V3 4/4] acpi, apei: use EFI memmap to map GHES memory

2015-06-11 Thread Jonathan (Zhixiong) Zhang
From: "Jonathan (Zhixiong) Zhang" With ACPI APEI firmware first handling, generic hardware error record is updated by firmware in GHES memory region. When firmware updated GHES memory region with uncached access attribute, Linux reads stale data from cache. GHES memory region should be mapped wi