Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-03-29 Thread Geert Uytterhoeven
Hi Adam, On Mon, Mar 29, 2021 at 2:45 PM Adam Ford wrote: > On Thu, Mar 4, 2021 at 2:08 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > > For devices that use a programmable clock for the AVB reference clock, > > > the driver may need to enable them.

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-03-29 Thread Adam Ford
On Thu, Mar 4, 2021 at 2:08 AM Geert Uytterhoeven wrote: > > Hi Adam, > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > For devices that use a programmable clock for the AVB reference clock, > > the driver may need to enable them. Add code to find the optional clock > > and enable it

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-03-04 Thread Geert Uytterhoeven
Hi Adam, On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > For devices that use a programmable clock for the AVB reference clock, > the driver may need to enable them. Add code to find the optional clock > and enable it when available. > > Signed-off-by: Adam Ford Thanks for your patch! >

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-02-24 Thread Andrew Lunn
> @@ -2260,6 +2267,9 @@ static int ravb_remove(struct platform_device *pdev) > if (priv->chip_id != RCAR_GEN2) > ravb_ptp_stop(ndev); > > + if (priv->refclk) > + clk_disable_unprepare(priv->refclk); > + Hi Adam You don't need the if (). The clk API is happy

[PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-02-24 Thread Adam Ford
For devices that use a programmable clock for the AVB reference clock, the driver may need to enable them. Add code to find the optional clock and enable it when available. Signed-off-by: Adam Ford --- V3: Change 'avb' to 'AVB' Remove unnessary else statement and pointer maniupluation