RE: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-28 Thread Sonal Santan
mek ; Stefano Stabellini ; > devicet...@vger.kernel.org; r...@kernel.org; Max Zhen > Subject: Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile > updates for XRT drivers > > On Sun, Feb 21, 2021 at 06:57:31AM -0800, Tom Rix wrote: > > As I am looking through

Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-21 Thread Moritz Fischer
On Sun, Feb 21, 2021 at 06:57:31AM -0800, Tom Rix wrote: > As I am looking through the files, I have this comment. > > fpga/ is currently a single directory, while files could be organized in > subdirectories like > > dfl/pci.c > > instead have the possible subdir name as a prefix to the

Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-21 Thread Tom Rix
As I am looking through the files, I have this comment. fpga/ is currently a single directory, while files could be organized in subdirectories like dfl/pci.c instead have the possible subdir name as a prefix to the filename. dfl-pci.c For consistency, xrt/metadata/metadata.c should be

Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-18 Thread kernel test robot
Hi Lizhi, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.11 next-20210218] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-18 Thread kernel test robot
Hi Lizhi, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.11 next-20210217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

[PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-17 Thread Lizhi Hou
Update fpga Kconfig/Makefile and add Kconfig/Makefile for new drivers. Signed-off-by: Sonal Santan Signed-off-by: Max Zhen Signed-off-by: Lizhi Hou --- MAINTAINERS| 11 +++ drivers/Makefile | 1 + drivers/fpga/Kconfig | 2 ++