Re: [PATCH V33 03/30] security: Add a static lockdown policy LSM

2019-06-21 Thread Mimi Zohar
On Thu, 2019-06-20 at 18:19 -0700, Matthew Garrett wrote: > --- a/Documentation/admin-guide/kernel-parameters.txt > +++ b/Documentation/admin-guide/kernel-parameters.txt > @@ -2239,6 +2239,15 @@ > lockd.nlm_udpport=M [NFS] Assign UDP port. > Format: > > + loc

Re: [PATCH V33 03/30] security: Add a static lockdown policy LSM

2019-06-21 Thread Matthew Garrett
On Fri, Jun 21, 2019 at 12:37 PM Matthew Garrett wrote: > I'll check, I'm bad at finding these new fangled things. Ah, I see - there's sysfs_match_string(), but that doesn't really work for this case because we'd still need to do another set of checks to see whether the level we get is in lockdow

Re: [PATCH V33 03/30] security: Add a static lockdown policy LSM

2019-06-21 Thread Matthew Garrett
On Thu, Jun 20, 2019 at 8:44 PM Kees Cook wrote: > > On Thu, Jun 20, 2019 at 06:19:14PM -0700, Matthew Garrett wrote: > > +/* > > + * If you add to this, remember to extend lockdown_reasons in > > + * security/lockdown/lockdown.c. > > + */ > > Best to add something like: > > BUILD_BUG_ON(ARRAY_S

Re: [PATCH V33 03/30] security: Add a static lockdown policy LSM

2019-06-20 Thread Kees Cook
On Thu, Jun 20, 2019 at 06:19:14PM -0700, Matthew Garrett wrote: > While existing LSMs can be extended to handle lockdown policy, > distributions generally want to be able to apply a straightforward > static policy. This patch adds a simple LSM that can be configured to > reject either integrity or

[PATCH V33 03/30] security: Add a static lockdown policy LSM

2019-06-20 Thread Matthew Garrett
While existing LSMs can be extended to handle lockdown policy, distributions generally want to be able to apply a straightforward static policy. This patch adds a simple LSM that can be configured to reject either integrity or all lockdown queries, and can be configured at runtime (through security