Re: [PATCH V34 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-06-27 Thread Matthew Garrett
On Wed, Jun 26, 2019 at 6:49 PM Daniel Axtens wrote: > > Matthew Garrett writes: > > + if (kp->flags & KERNEL_PARAM_FL_HWPARAM && > > + security_locked_down(LOCKDOWN_MODULE_PARAMETERS)) > > + return false; > > + return true; > > } > > Should this test occur before

Re: [PATCH V34 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-06-26 Thread Daniel Axtens
Matthew Garrett writes: > From: David Howells > > Provided an annotation for module parameters that specify hardware > parameters (such as io ports, iomem addresses, irqs, dma channels, fixed > dma buffers and other types). > > Suggested-by: Alan Cox > Signed-off-by: David Howells >

Re: [PATCH V34 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-06-22 Thread Kees Cook
On Fri, Jun 21, 2019 at 05:03:48PM -0700, Matthew Garrett wrote: > From: David Howells > > Provided an annotation for module parameters that specify hardware > parameters (such as io ports, iomem addresses, irqs, dma channels, fixed > dma buffers and other types). > > Suggested-by: Alan Cox >

[PATCH V34 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-06-21 Thread Matthew Garrett
From: David Howells Provided an annotation for module parameters that specify hardware parameters (such as io ports, iomem addresses, irqs, dma channels, fixed dma buffers and other types). Suggested-by: Alan Cox Signed-off-by: David Howells Signed-off-by: Matthew Garrett ---