Re: [PATCH V38 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-08-08 Thread James Morris
On Thu, 8 Aug 2019, Jessica Yu wrote: > > +#ifdef CONFIG_MODULES > > +#define mod_name(mod) ((mod)->name) > > +#else > > +#define mod_name(mod) "unknown" > > +#endif > > + > > Hm, I don't think mod_name is used anywhere? > > But other than that: > > Acked-by: Jessica Yu > Matthew: no need

Re: [PATCH V38 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-08-08 Thread Jessica Yu
+++ Matthew Garrett [07/08/19 17:07 -0700]: From: David Howells Provided an annotation for module parameters that specify hardware parameters (such as io ports, iomem addresses, irqs, dma channels, fixed dma buffers and other types). Suggested-by: Alan Cox Signed-off-by: David Howells

[PATCH V38 19/29] Lock down module params that specify hardware parameters (eg. ioport)

2019-08-07 Thread Matthew Garrett
From: David Howells Provided an annotation for module parameters that specify hardware parameters (such as io ports, iomem addresses, irqs, dma channels, fixed dma buffers and other types). Suggested-by: Alan Cox Signed-off-by: David Howells Signed-off-by: Matthew Garrett Reviewed-by: Kees