Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
On 6/6/19 1:45 PM, Peter Rosin wrote: On 2019-06-06 09:35, Bitan Biswas wrote: Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Replace BUG() with error handling code. Define I2C_ERR_UNEXPECTED_STATUS for

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Peter Rosin
On 2019-06-06 09:35, Bitan Biswas wrote: > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c > > Remove redundant BUG_ON calls or replace with WARN_ON_ONCE > as needed. Replace BUG() with error handling code. > Define I2C_ERR_UNEXPECTED_STATUS for error handling. > > Signed-off-by:

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
On 6/6/19 4:57 AM, Wolfram Sang wrote: On Thu, Jun 06, 2019 at 12:35:23AM -0700, Bitan Biswas wrote: Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Replace BUG() with error handling code. Define

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Dmitry Osipenko
06.06.2019 17:02, Bitan Biswas пишет: > > > On 6/6/19 4:39 AM, Dmitry Osipenko wrote: >> 06.06.2019 10:35, Bitan Biswas пишет: >>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >>> >>> Remove redundant BUG_ON calls or replace with WARN_ON_ONCE >>> as needed. Replace BUG() with

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
On 6/6/19 4:39 AM, Dmitry Osipenko wrote: 06.06.2019 10:35, Bitan Biswas пишет: Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Replace BUG() with error handling code. Define I2C_ERR_UNEXPECTED_STATUS for

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Wolfram Sang
On Thu, Jun 06, 2019 at 12:35:23AM -0700, Bitan Biswas wrote: > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c > > Remove redundant BUG_ON calls or replace with WARN_ON_ONCE > as needed. Replace BUG() with error handling code. > Define I2C_ERR_UNEXPECTED_STATUS for error handling.

Re: [PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Dmitry Osipenko
06.06.2019 10:35, Bitan Biswas пишет: > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c > > Remove redundant BUG_ON calls or replace with WARN_ON_ONCE > as needed. Replace BUG() with error handling code. > Define I2C_ERR_UNEXPECTED_STATUS for error handling. > > Signed-off-by:

[PATCH V4] drivers: i2c: tegra: fix checkpatch defects

2019-06-06 Thread Bitan Biswas
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Replace BUG() with error handling code. Define I2C_ERR_UNEXPECTED_STATUS for error handling. Signed-off-by: Bitan Biswas --- drivers/i2c/busses/i2c-tegra.c | 67