Re: [PATCH V4] regulator: DA9211 : new regulator driver

2014-07-09 Thread Mark Brown
On Wed, Jul 09, 2014 at 05:57:56PM +0900, James Ban wrote: > Thanks for your comment. Is below code O.K.? Yes. signature.asc Description: Digital signature

Re: [PATCH V4] regulator: DA9211 : new regulator driver

2014-07-09 Thread James Ban
> -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Wednesday, July 09, 2014 5:39 PM > To: Opensource [James Seong-Won Ban] > Cc: Liam Girdwood; Support Opensource; LKML; David Dajun Chen > Subject: Re: [PATCH V4] regulator: DA9211 : new regulator

Re: [PATCH V4] regulator: DA9211 : new regulator driver

2014-07-09 Thread Mark Brown
On Wed, Jul 09, 2014 at 05:28:59PM +0900, James Ban wrote: > How about below code for proper handle of interrupt? That's fine, or you could have a return value which defaults to IRQ_NONE and then set it to IRQ_HANDLED when you handle a particular bit - that is more common since that way if multip

Re: [PATCH V4] regulator: DA9211 : new regulator driver

2014-07-09 Thread James Ban
> -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Wednesday, July 09, 2014 4:57 PM > To: Opensource [James Seong-Won Ban] > Cc: Liam Girdwood; Support Opensource; LKML; David Dajun Chen > Subject: Re: your mail > > On Wed, Jul 09, 2014 at 10:03:32AM +0900, James B

Re: [PATCH V4] regulator: DA9211 : new regulator driver

2014-07-08 Thread James Ban
ect: Re: [PATCH V4] regulator: DA9211 : new regulator driver > > On Thu, Jul 03, 2014 at 04:29:03PM +0900, James Ban wrote: > > This is greatly improved, thanks, however there are still a few issues which > should be addressed: > > > +static irqreturn_t da9211_irq_handler(in

Re: [PATCH V4] regulator: DA9211 : new regulator driver

2014-07-08 Thread Mark Brown
On Thu, Jul 03, 2014 at 04:29:03PM +0900, James Ban wrote: This is greatly improved, thanks, however there are still a few issues which should be addressed: > +static irqreturn_t da9211_irq_handler(int irq, void *data) > +{ > + struct da9211 *chip = data; > + int reg_val, ret; > + > +

[PATCH V4] regulator: DA9211 : new regulator driver

2014-07-03 Thread James Ban
This is the driver for the Dialog DA9211 Multi-phase 12A DC-DC Buck Converter regulator. It communicates via an I2C bus to the device. Signed-off-by: James Ban --- This patch is relative to linux-next repository tag next-20140630. Changes in V4: - Stripped out the suspend and GPIO handling. Ch