Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-23 Thread Michael Ellerman
On Tue, 2013-12-24 at 09:20 +0530, Anshuman Khandual wrote: > On 12/24/2013 08:59 AM, Michael Ellerman wrote: > > On Fri, 2013-12-20 at 16:31 +0530, Anshuman Khandual wrote: > >> On 12/09/2013 11:51 AM, Michael Ellerman wrote: > >>> On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: >

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-23 Thread Anshuman Khandual
On 12/24/2013 08:59 AM, Michael Ellerman wrote: > On Fri, 2013-12-20 at 16:31 +0530, Anshuman Khandual wrote: >> On 12/09/2013 11:51 AM, Michael Ellerman wrote: >>> On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: + + if (bhrb_sw_filter & PERF_SAMPLE_BRANCH_IND_CALL) {

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-23 Thread Michael Ellerman
On Fri, 2013-12-20 at 16:31 +0530, Anshuman Khandual wrote: > On 12/09/2013 11:51 AM, Michael Ellerman wrote: > > On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: > >> + > >> + if (bhrb_sw_filter & PERF_SAMPLE_BRANCH_IND_CALL) { > >> + /* XL-form instruction */ > >> +

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-23 Thread Michael Ellerman
On Fri, 2013-12-20 at 16:31 +0530, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: + + if (bhrb_sw_filter PERF_SAMPLE_BRANCH_IND_CALL) { + /* XL-form instruction */ + if

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-23 Thread Anshuman Khandual
On 12/24/2013 08:59 AM, Michael Ellerman wrote: On Fri, 2013-12-20 at 16:31 +0530, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: + + if (bhrb_sw_filter PERF_SAMPLE_BRANCH_IND_CALL) { + /*

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-23 Thread Michael Ellerman
On Tue, 2013-12-24 at 09:20 +0530, Anshuman Khandual wrote: On 12/24/2013 08:59 AM, Michael Ellerman wrote: On Fri, 2013-12-20 at 16:31 +0530, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: + +

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-20 Thread Anshuman Khandual
On 12/09/2013 11:51 AM, Michael Ellerman wrote: > On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: >> This patch enables SW based post processing of BHRB captured branches >> to be able to meet more user defined branch filtration criteria in perf >> branch stack sampling framework.

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-20 Thread Anshuman Khandual
On 12/09/2013 11:51 AM, Michael Ellerman wrote: On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: This patch enables SW based post processing of BHRB captured branches to be able to meet more user defined branch filtration criteria in perf branch stack sampling framework. These

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-12 Thread Michael Ellerman
On Thu, 2013-12-12 at 14:15 +0530, Anshuman Khandual wrote: > On 12/10/2013 11:27 AM, Anshuman Khandual wrote: > > On 12/09/2013 11:51 AM, Michael Ellerman wrote: > >> This code was already in need of some unindentation, and now it's just > >> ridiculous. > >> > >> To start with at the beginning

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-12 Thread Anshuman Khandual
On 12/10/2013 11:27 AM, Anshuman Khandual wrote: > On 12/09/2013 11:51 AM, Michael Ellerman wrote: >> This code was already in need of some unindentation, and now it's just >> ridiculous. >> >> To start with at the beginning of this routine we have: >> >> while (..) { >> if (!val) >>

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-12 Thread Anshuman Khandual
On 12/10/2013 11:27 AM, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: This code was already in need of some unindentation, and now it's just ridiculous. To start with at the beginning of this routine we have: while (..) { if (!val) break;

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-12 Thread Michael Ellerman
On Thu, 2013-12-12 at 14:15 +0530, Anshuman Khandual wrote: On 12/10/2013 11:27 AM, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: This code was already in need of some unindentation, and now it's just ridiculous. To start with at the beginning of this routine

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-09 Thread Anshuman Khandual
On 12/09/2013 11:51 AM, Michael Ellerman wrote: > This code was already in need of some unindentation, and now it's just > ridiculous. > > To start with at the beginning of this routine we have: > > while (..) { > if (!val) > break; > else { > // Bulk of

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-09 Thread Anshuman Khandual
On 12/09/2013 11:51 AM, Michael Ellerman wrote: This code was already in need of some unindentation, and now it's just ridiculous. To start with at the beginning of this routine we have: while (..) { if (!val) break; else { // Bulk of the logic

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-08 Thread Michael Ellerman
On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: > This patch enables SW based post processing of BHRB captured branches > to be able to meet more user defined branch filtration criteria in perf > branch stack sampling framework. These changes increase the number of > branch filters

Re: [PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-08 Thread Michael Ellerman
On Wed, 2013-04-12 at 10:32:40 UTC, Anshuman Khandual wrote: This patch enables SW based post processing of BHRB captured branches to be able to meet more user defined branch filtration criteria in perf branch stack sampling framework. These changes increase the number of branch filters and

[PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-04 Thread Anshuman Khandual
This patch enables SW based post processing of BHRB captured branches to be able to meet more user defined branch filtration criteria in perf branch stack sampling framework. These changes increase the number of branch filters and their valid combinations on any powerpc64 server platform with BHRB

[PATCH V4 08/10] powerpc, perf: Enable SW filtering in branch stack sampling framework

2013-12-04 Thread Anshuman Khandual
This patch enables SW based post processing of BHRB captured branches to be able to meet more user defined branch filtration criteria in perf branch stack sampling framework. These changes increase the number of branch filters and their valid combinations on any powerpc64 server platform with BHRB