Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-17 Thread Anshuman Khandual
On 12/18/2013 05:38 AM, Michael Ellerman wrote: > On Fri, 2013-12-13 at 13:50 +0530, Anshuman Khandual wrote: >> On 12/09/2013 11:51 AM, Michael Ellerman wrote: >>> >>> As I said in my comments on version 3 which you ignored: >>> >>> I think it would be clearer if we actually checked for the

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-17 Thread Michael Ellerman
On Fri, 2013-12-13 at 13:50 +0530, Anshuman Khandual wrote: > On 12/09/2013 11:51 AM, Michael Ellerman wrote: > > > > As I said in my comments on version 3 which you ignored: > > > > I think it would be clearer if we actually checked for the > > possibilities we > > allow and let

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-17 Thread Michael Ellerman
On Fri, 2013-12-13 at 13:50 +0530, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: As I said in my comments on version 3 which you ignored: I think it would be clearer if we actually checked for the possibilities we allow and let everything else

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-17 Thread Anshuman Khandual
On 12/18/2013 05:38 AM, Michael Ellerman wrote: On Fri, 2013-12-13 at 13:50 +0530, Anshuman Khandual wrote: On 12/09/2013 11:51 AM, Michael Ellerman wrote: As I said in my comments on version 3 which you ignored: I think it would be clearer if we actually checked for the possibilities

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-13 Thread Anshuman Khandual
On 12/09/2013 11:51 AM, Michael Ellerman wrote: > > As I said in my comments on version 3 which you ignored: > > I think it would be clearer if we actually checked for the possibilities > we > allow and let everything else fall through, eg: > > Â Â Â Â Â Â Â Â /* Ignore user/kernel/hv

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-13 Thread Anshuman Khandual
On 12/09/2013 11:51 AM, Michael Ellerman wrote: As I said in my comments on version 3 which you ignored: I think it would be clearer if we actually checked for the possibilities we allow and let everything else fall through, eg: Â Â Â Â Â Â Â Â /* Ignore user/kernel/hv bits */

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-08 Thread Michael Ellerman
On Wed, 2013-04-12 at 10:32:41 UTC, Anshuman Khandual wrote: > Powerpc kernel now supports SW based branch filters for book3s systems with > some > specifc requirements while dealing with HW supported branch filters in order > to > achieve overall OR semantics prevailing in perf branch stack

Re: [PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-08 Thread Michael Ellerman
On Wed, 2013-04-12 at 10:32:41 UTC, Anshuman Khandual wrote: Powerpc kernel now supports SW based branch filters for book3s systems with some specifc requirements while dealing with HW supported branch filters in order to achieve overall OR semantics prevailing in perf branch stack sampling

[PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-04 Thread Anshuman Khandual
Powerpc kernel now supports SW based branch filters for book3s systems with some specifc requirements while dealing with HW supported branch filters in order to achieve overall OR semantics prevailing in perf branch stack sampling framework. This patch adapts the BHRB branch filter configuration

[PATCH V4 09/10] power8, perf: Change BHRB branch filter configuration

2013-12-04 Thread Anshuman Khandual
Powerpc kernel now supports SW based branch filters for book3s systems with some specifc requirements while dealing with HW supported branch filters in order to achieve overall OR semantics prevailing in perf branch stack sampling framework. This patch adapts the BHRB branch filter configuration