Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-23 Thread Hillf Danton
On February 23, 2017 2:51 AM Shaohua Li wrote: > > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is unnecessary. If

Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-23 Thread Hillf Danton
On February 23, 2017 2:51 AM Shaohua Li wrote: > > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is unnecessary. If

Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-23 Thread Minchan Kim
On Wed, Feb 22, 2017 at 10:50:39AM -0800, Shaohua Li wrote: > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is

Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-23 Thread Minchan Kim
On Wed, Feb 22, 2017 at 10:50:39AM -0800, Shaohua Li wrote: > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is

Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-23 Thread Johannes Weiner
On Wed, Feb 22, 2017 at 10:50:39AM -0800, Shaohua Li wrote: > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is

Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-23 Thread Johannes Weiner
On Wed, Feb 22, 2017 at 10:50:39AM -0800, Shaohua Li wrote: > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is

[PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-22 Thread Shaohua Li
Johannes pointed out TTU_LZFREE is unnecessary. It's true because we always have the flag set if we want to do an unmap. For cases we don't do an unmap, the TTU_LZFREE part of code should never run. Also the TTU_UNMAP is unnecessary. If no other flags set (for example, TTU_MIGRATION), an unmap is

[PATCH V4 1/6] mm: delete unnecessary TTU_* flags

2017-02-22 Thread Shaohua Li
Johannes pointed out TTU_LZFREE is unnecessary. It's true because we always have the flag set if we want to do an unmap. For cases we don't do an unmap, the TTU_LZFREE part of code should never run. Also the TTU_UNMAP is unnecessary. If no other flags set (for example, TTU_MIGRATION), an unmap is