Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-29 Thread Tejun Heo
Hello, On Tue, Nov 29, 2016 at 10:30:44AM -0800, Shaohua Li wrote: > > As discussed separately, it might make more sense to just use the avg > > of the closest bucket instead of trying to line-fit the buckets, but > > it's an implementation detail and whatever which works is fine. > > that is

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-29 Thread Tejun Heo
Hello, On Tue, Nov 29, 2016 at 10:30:44AM -0800, Shaohua Li wrote: > > As discussed separately, it might make more sense to just use the avg > > of the closest bucket instead of trying to line-fit the buckets, but > > it's an implementation detail and whatever which works is fine. > > that is

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-29 Thread Shaohua Li
On Tue, Nov 29, 2016 at 12:24:35PM -0500, Tejun Heo wrote: > Hello, Shaohua. > > On Mon, Nov 14, 2016 at 02:22:20PM -0800, Shaohua Li wrote: > > To do this, we sample some data, eg, average latency for request size > > 4k, 8k, 16k, 32k, 64k. We then use an equation f(x) = a * x + b to fit > > the

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-29 Thread Shaohua Li
On Tue, Nov 29, 2016 at 12:24:35PM -0500, Tejun Heo wrote: > Hello, Shaohua. > > On Mon, Nov 14, 2016 at 02:22:20PM -0800, Shaohua Li wrote: > > To do this, we sample some data, eg, average latency for request size > > 4k, 8k, 16k, 32k, 64k. We then use an equation f(x) = a * x + b to fit > > the

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-29 Thread Tejun Heo
Hello, Shaohua. On Mon, Nov 14, 2016 at 02:22:20PM -0800, Shaohua Li wrote: > To do this, we sample some data, eg, average latency for request size > 4k, 8k, 16k, 32k, 64k. We then use an equation f(x) = a * x + b to fit > the data (x is request size in KB, f(x) is the latency). Then we can use >

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-29 Thread Tejun Heo
Hello, Shaohua. On Mon, Nov 14, 2016 at 02:22:20PM -0800, Shaohua Li wrote: > To do this, we sample some data, eg, average latency for request size > 4k, 8k, 16k, 32k, 64k. We then use an equation f(x) = a * x + b to fit > the data (x is request size in KB, f(x) is the latency). Then we can use >

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-14 Thread kbuild test robot
Hi Shaohua, [auto build test WARNING on linus/master] [also build test WARNING on v4.9-rc5] [cannot apply to block/for-next next-20161114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-14 Thread kbuild test robot
Hi Shaohua, [auto build test WARNING on linus/master] [also build test WARNING on v4.9-rc5] [cannot apply to block/for-next next-20161114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-14 Thread kbuild test robot
Hi Shaohua, [auto build test WARNING on linus/master] [also build test WARNING on v4.9-rc5] [cannot apply to block/for-next next-20161114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-14 Thread kbuild test robot
Hi Shaohua, [auto build test WARNING on linus/master] [also build test WARNING on v4.9-rc5] [cannot apply to block/for-next next-20161114] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-14 Thread Shaohua Li
We try to set a latency target for each cgroup. The problem is latency highly depends on request size, users can't configure the target for every request size. The idea is users configure latency target for 4k IO, we estimate the target latency for other request size IO. To do this, we sample

[PATCH V4 13/15] blk-throttle: add a mechanism to estimate IO latency

2016-11-14 Thread Shaohua Li
We try to set a latency target for each cgroup. The problem is latency highly depends on request size, users can't configure the target for every request size. The idea is users configure latency target for 4k IO, we estimate the target latency for other request size IO. To do this, we sample