Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-23 Thread Sinan Kaya
On 10/21/2016 12:13 PM, Sinan Kaya wrote: >> Wait a minute, I still have a question here: what about other ACPI >> > arches (ia64, arm64)? Don't they need to call acpi_penalize_sci_irq() >> > somewhere? >> > > ACPI ARM64 architecture implements reduced ACPI profile which doesn't > have GED

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-23 Thread Sinan Kaya
On 10/21/2016 12:13 PM, Sinan Kaya wrote: >> Wait a minute, I still have a question here: what about other ACPI >> > arches (ia64, arm64)? Don't they need to call acpi_penalize_sci_irq() >> > somewhere? >> > > ACPI ARM64 architecture implements reduced ACPI profile which doesn't > have GED

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-23 Thread Sinan Kaya
On 10/20/2016 9:58 PM, Bjorn Helgaas wrote: > I like this patch fine, except for the changelog. I don't think it's > useful to describe this as a revert and give all the historical > details. I think the important part is something like this: > > We previously used irq_get_trigger_type(irq)

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-23 Thread Sinan Kaya
On 10/20/2016 9:58 PM, Bjorn Helgaas wrote: > I like this patch fine, except for the changelog. I don't think it's > useful to describe this as a revert and give all the historical > details. I think the important part is something like this: > > We previously used irq_get_trigger_type(irq)

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-22 Thread Bjorn Helgaas
On Thu, Oct 20, 2016 at 08:58:14PM -0500, Bjorn Helgaas wrote: > On Wed, Oct 19, 2016 at 06:21:03PM -0400, Sinan Kaya wrote: > > The SCI penalize function was removed in two steps (first refactor > > and then remove) and these changes are reverted here in one go. > > > > The commit 103544d86976

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-22 Thread Bjorn Helgaas
On Thu, Oct 20, 2016 at 08:58:14PM -0500, Bjorn Helgaas wrote: > On Wed, Oct 19, 2016 at 06:21:03PM -0400, Sinan Kaya wrote: > > The SCI penalize function was removed in two steps (first refactor > > and then remove) and these changes are reverted here in one go. > > > > The commit 103544d86976

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-22 Thread Bjorn Helgaas
On Fri, Oct 21, 2016 at 09:13:06AM -0700, Sinan Kaya wrote: > On 10/21/2016 7:45 AM, Bjorn Helgaas wrote: > > [1] http://marc.info/?l=linux-acpi=145580159209240=2) > > > >> > Acked-by: Bjorn Helgaas > > Wait a minute, I still have a question here: what about other ACPI > >

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-22 Thread Bjorn Helgaas
On Fri, Oct 21, 2016 at 09:13:06AM -0700, Sinan Kaya wrote: > On 10/21/2016 7:45 AM, Bjorn Helgaas wrote: > > [1] http://marc.info/?l=linux-acpi=145580159209240=2) > > > >> > Acked-by: Bjorn Helgaas > > Wait a minute, I still have a question here: what about other ACPI > > arches (ia64, arm64)?

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-21 Thread Sinan Kaya
On 10/21/2016 7:45 AM, Bjorn Helgaas wrote: > [1] http://marc.info/?l=linux-acpi=145580159209240=2) > >> > Acked-by: Bjorn Helgaas > Wait a minute, I still have a question here: what about other ACPI > arches (ia64, arm64)? Don't they need to call acpi_penalize_sci_irq() >

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-21 Thread Sinan Kaya
On 10/21/2016 7:45 AM, Bjorn Helgaas wrote: > [1] http://marc.info/?l=linux-acpi=145580159209240=2) > >> > Acked-by: Bjorn Helgaas > Wait a minute, I still have a question here: what about other ACPI > arches (ia64, arm64)? Don't they need to call acpi_penalize_sci_irq() > somewhere? > ACPI

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-21 Thread Bjorn Helgaas
On Thu, Oct 20, 2016 at 08:58:14PM -0500, Bjorn Helgaas wrote: > On Wed, Oct 19, 2016 at 06:21:03PM -0400, Sinan Kaya wrote: > > The SCI penalize function was removed in two steps (first refactor > > and then remove) and these changes are reverted here in one go. > > > > The commit 103544d86976

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-21 Thread Bjorn Helgaas
On Thu, Oct 20, 2016 at 08:58:14PM -0500, Bjorn Helgaas wrote: > On Wed, Oct 19, 2016 at 06:21:03PM -0400, Sinan Kaya wrote: > > The SCI penalize function was removed in two steps (first refactor > > and then remove) and these changes are reverted here in one go. > > > > The commit 103544d86976

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-20 Thread Bjorn Helgaas
On Wed, Oct 19, 2016 at 06:21:03PM -0400, Sinan Kaya wrote: > The SCI penalize function was removed in two steps (first refactor > and then remove) and these changes are reverted here in one go. > > The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements") > refactored the original

Re: [PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-20 Thread Bjorn Helgaas
On Wed, Oct 19, 2016 at 06:21:03PM -0400, Sinan Kaya wrote: > The SCI penalize function was removed in two steps (first refactor > and then remove) and these changes are reverted here in one go. > > The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements") > refactored the original

[PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-19 Thread Sinan Kaya
The SCI penalize function was removed in two steps (first refactor and then remove) and these changes are reverted here in one go. The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements") refactored the original code so that SCI penalty is calculated dynamically by the time

[PATCH V4 2/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-19 Thread Sinan Kaya
The SCI penalize function was removed in two steps (first refactor and then remove) and these changes are reverted here in one go. The commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements") refactored the original code so that SCI penalty is calculated dynamically by the time