Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-31 Thread Lee Jones
On Wed, 29 Jul 2020, Mark D Rustad wrote: > at 12:58 AM, Lee Jones wrote: > > > If you do: > > > > do { > > int pos; > > > > pos = pci_find_next_ext_capability(pdev, pos, > > PCI_EXT_CAP_ID_DVSEC); > > if (!pos) > > break; > > > >

Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-30 Thread David E. Box
On Wed, 2020-07-29 at 15:59 -0700, Mark D Rustad wrote: > at 12:58 AM, Lee Jones wrote: > > > If you do: > > > > do { > > int pos; > > > > pos = pci_find_next_ext_capability(pdev, pos, > > PCI_EXT_CAP_ID_DVSEC); > > if (!pos) > >

Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-29 Thread Mark D Rustad
at 12:58 AM, Lee Jones wrote: If you do: do { int pos; pos = pci_find_next_ext_capability(pdev, pos, PCI_EXT_CAP_ID_DVSEC); if (!pos) break; Then you can invoke pci_find_next_ext_capability() once, no? Part

Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-28 Thread David E. Box
Hi Lee, Thanks for this thorough review. Ack on all the comments with particular thanks for spoting the missing continue. David On Tue, 2020-07-28 at 08:58 +0100, Lee Jones wrote: > On Fri, 17 Jul 2020, David E. Box wrote: > > > Intel Platform Monitoring Technology (PMT) is an architecture for

Re: [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-28 Thread Lee Jones
On Fri, 17 Jul 2020, David E. Box wrote: > Intel Platform Monitoring Technology (PMT) is an architecture for > enumerating and accessing hardware monitoring facilities. PMT supports > multiple types of monitoring capabilities. This driver creates platform > devices for each type so that they may

[PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support

2020-07-17 Thread David E. Box
Intel Platform Monitoring Technology (PMT) is an architecture for enumerating and accessing hardware monitoring facilities. PMT supports multiple types of monitoring capabilities. This driver creates platform devices for each type so that they may be managed by capability specific drivers (to be