Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-07 Thread Borislav Petkov
On Thu, Feb 07, 2019 at 06:00:53PM +0100, Daniel Bristot de Oliveira wrote: > It is taking 95 characters. In this case, wouldn't be better to break? > > if (!kernel_text_address(jump_entry_code(entry))) { > WARN_ONCE(1, "can't patch jump_label at %pS", >

Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-07 Thread Daniel Bristot de Oliveira
On 2/7/19 3:08 PM, Borislav Petkov wrote: > On Thu, Feb 07, 2019 at 02:21:09PM +0100, Daniel Bristot de Oliveira wrote: >> diff --git a/kernel/jump_label.c b/kernel/jump_label.c >> index 288d630da22d..1e6f4d27e28d 100644 >> --- a/kernel/jump_label.c >> +++ b/kernel/jump_label.c >> @@ -374,22 +374,2

Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-07 Thread Borislav Petkov
On Thu, Feb 07, 2019 at 02:21:09PM +0100, Daniel Bristot de Oliveira wrote: > diff --git a/kernel/jump_label.c b/kernel/jump_label.c > index 288d630da22d..1e6f4d27e28d 100644 > --- a/kernel/jump_label.c > +++ b/kernel/jump_label.c > @@ -374,22 +374,29 @@ static enum jump_label_type jump_label_type(

Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-07 Thread Daniel Bristot de Oliveira
On 2/5/19 10:13 PM, Borislav Petkov wrote: > On Tue, Feb 05, 2019 at 02:50:39PM +0100, Daniel Bristot de Oliveira wrote: + if (jump_label_can_update_check(entry, init)) { + arch_jump_label_transform(entry, +jump_la

Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-05 Thread Borislav Petkov
On Tue, Feb 05, 2019 at 02:50:39PM +0100, Daniel Bristot de Oliveira wrote: > >> + if (jump_label_can_update_check(entry, init)) { > >> + arch_jump_label_transform(entry, > >> +jump_label_type(entry)); > > > > Yeah, let that one

Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-05 Thread Daniel Bristot de Oliveira
Hi Borislav! On 2/5/19 8:22 AM, Borislav Petkov wrote: >> Subject: Re: [PATCH V4 2/9] jump_label: Add the >> jump_label_can_update_check() helper > > s/the/a/ ack! > On Mon, Feb 04, 2019 at 08:58:55PM +0100, Daniel Bristot de Oliveira wrote: >> Move the check of if

Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-04 Thread Borislav Petkov
> Subject: Re: [PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() > helper s/the/a/ On Mon, Feb 04, 2019 at 08:58:55PM +0100, Daniel Bristot de Oliveira wrote: > Move the check of if a jump_entry is valid to a function. s/of // > diff --git a/kernel/jump_labe

[PATCH V4 2/9] jump_label: Add the jump_label_can_update_check() helper

2019-02-04 Thread Daniel Bristot de Oliveira
Move the check of if a jump_entry is valid to a function. Signed-off-by: Daniel Bristot de Oliveira Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Greg Kroah-Hartman Cc: Masami Hiramatsu Cc: "Steven Rostedt (VMware)" Cc: Jiri Kosina Cc: Josh Poimboeuf Cc