Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-30 Thread Christoph Hellwig
On Mon, Jul 30, 2012 at 11:25:51AM +0930, Rusty Russell wrote: > I consider this approach a half-way step. Quick attempts on my laptop > and I couldn't find a case where the bio path was a loss, but in theory > if the host wasn't doing any reordering and it was a slow device, you'd > want the gues

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Asias He
Hello Sasha, On 07/28/2012 02:35 PM, Sasha Levin wrote: On 07/28/2012 04:21 AM, Asias He wrote: This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided ->make_request_fn() method to bypasses the IO scheduler. It handles

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Asias He
On 07/29/2012 07:11 PM, Michael S. Tsirkin wrote: On Sat, Jul 28, 2012 at 10:21:05AM +0800, Asias He wrote: This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided ->make_request_fn() method to bypasses the IO scheduler.

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Rusty Russell
On Sun, 29 Jul 2012 14:11:15 +0300, "Michael S. Tsirkin" wrote: > On Sat, Jul 28, 2012 at 10:21:05AM +0800, Asias He wrote: > > This patch introduces bio-based IO path for virtio-blk. > > > > Compared to request-based IO path, bio-based IO path uses driver > > provided ->make_request_fn() method

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Michael S. Tsirkin
On Sat, Jul 28, 2012 at 10:21:05AM +0800, Asias He wrote: > This patch introduces bio-based IO path for virtio-blk. > > Compared to request-based IO path, bio-based IO path uses driver > provided ->make_request_fn() method to bypasses the IO scheduler. It > handles the bio to device directly witho

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Sasha Levin
On 07/28/2012 04:21 AM, Asias He wrote: > This patch introduces bio-based IO path for virtio-blk. > > Compared to request-based IO path, bio-based IO path uses driver > provided ->make_request_fn() method to bypasses the IO scheduler. It > handles the bio to device directly without allocating a re

[PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Asias He
This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided ->make_request_fn() method to bypasses the IO scheduler. It handles the bio to device directly without allocating a request in block layer. This reduces the IO path in