Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-18 Thread Steven Rostedt
On Mon, Mar 16, 2015 at 09:49:56AM -0400, Eric B Munson wrote: > On Mon, 16 Mar 2015, Vlastimil Babka wrote: > > > [CC += linux-api@] > > > > Since this is a kernel-user-space API change, please CC linux-api@. > > The kernel source file Documentation/SubmitChecklist notes that all > > Linux

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-18 Thread Vlastimil Babka
On 03/16/2015 02:49 PM, Eric B Munson wrote: On Mon, 16 Mar 2015, Vlastimil Babka wrote: [CC += linux-api@] Since this is a kernel-user-space API change, please CC linux-api@. The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches that change userspace

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-18 Thread Vlastimil Babka
On 03/16/2015 02:49 PM, Eric B Munson wrote: On Mon, 16 Mar 2015, Vlastimil Babka wrote: [CC += linux-api@] Since this is a kernel-user-space API change, please CC linux-api@. The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches that change userspace

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-18 Thread Steven Rostedt
On Mon, Mar 16, 2015 at 09:49:56AM -0400, Eric B Munson wrote: On Mon, 16 Mar 2015, Vlastimil Babka wrote: [CC += linux-api@] Since this is a kernel-user-space API change, please CC linux-api@. The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-16 Thread Christoph Lameter
On Fri, 13 Mar 2015, David Rientjes wrote: > It would be really disappointing to not enable this by default for !rt > kernels. We haven't migrated mlocked pages in the past by way of memory > compaction because it can theoretically result in consistent minor page > faults, but I haven't yet

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-16 Thread Eric B Munson
On Mon, 16 Mar 2015, Vlastimil Babka wrote: > [CC += linux-api@] > > Since this is a kernel-user-space API change, please CC linux-api@. > The kernel source file Documentation/SubmitChecklist notes that all > Linux kernel patches that change userspace interfaces should be CCed > to

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-16 Thread Vlastimil Babka
[CC += linux-api@] Since this is a kernel-user-space API change, please CC linux-api@. The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches that change userspace interfaces should be CCed to linux-...@vger.kernel.org, so that the various parties who are

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-16 Thread Eric B Munson
On Mon, 16 Mar 2015, Vlastimil Babka wrote: [CC += linux-api@] Since this is a kernel-user-space API change, please CC linux-api@. The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches that change userspace interfaces should be CCed to

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-16 Thread Vlastimil Babka
[CC += linux-api@] Since this is a kernel-user-space API change, please CC linux-api@. The kernel source file Documentation/SubmitChecklist notes that all Linux kernel patches that change userspace interfaces should be CCed to linux-...@vger.kernel.org, so that the various parties who are

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-16 Thread Christoph Lameter
On Fri, 13 Mar 2015, David Rientjes wrote: It would be really disappointing to not enable this by default for !rt kernels. We haven't migrated mlocked pages in the past by way of memory compaction because it can theoretically result in consistent minor page faults, but I haven't yet heard a

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Rik van Riel
On 03/13/2015 07:18 PM, David Rientjes wrote: > On Fri, 13 Mar 2015, Eric B Munson wrote: > --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1046,6 +1046,8 @@ typedef enum { ISOLATE_SUCCESS,/* Pages isolated, migrate */ } isolate_migrate_t; +int

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread David Rientjes
On Fri, 13 Mar 2015, Eric B Munson wrote: > > > --- a/mm/compaction.c > > > +++ b/mm/compaction.c > > > @@ -1046,6 +1046,8 @@ typedef enum { > > > ISOLATE_SUCCESS,/* Pages isolated, migrate */ > > > } isolate_migrate_t; > > > > > > +int sysctl_compact_unevictable; > > > + > > > /* >

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Michal Hocko
On Fri 13-03-15 15:09:15, Eric B Munson wrote: > On Fri, 13 Mar 2015, Rik van Riel wrote: > > > On 03/13/2015 01:26 PM, Eric B Munson wrote: > > > > > --- a/mm/compaction.c > > > +++ b/mm/compaction.c > > > @@ -1046,6 +1046,8 @@ typedef enum { > > > ISOLATE_SUCCESS,/* Pages isolated,

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Michal Hocko
On Fri 13-03-15 13:26:37, Eric B Munson wrote: [...] > +compact_unevictable > + > +Available only when CONFIG_COMPACTION is set. When set to 1, compaction is > +allowed to examine the unevictable lru (mlocked pages) for pages to compact. > +This should be used on systems where stalls for minor

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Eric B Munson
On Fri, 13 Mar 2015, Rik van Riel wrote: > On 03/13/2015 01:26 PM, Eric B Munson wrote: > > > --- a/mm/compaction.c > > +++ b/mm/compaction.c > > @@ -1046,6 +1046,8 @@ typedef enum { > > ISOLATE_SUCCESS,/* Pages isolated, migrate */ > > } isolate_migrate_t; > > > > +int

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Rik van Riel
On 03/13/2015 01:26 PM, Eric B Munson wrote: > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1046,6 +1046,8 @@ typedef enum { > ISOLATE_SUCCESS,/* Pages isolated, migrate */ > } isolate_migrate_t; > > +int sysctl_compact_unevictable; > + > /* > * Isolate all pages that

[PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Eric B Munson
Currently, pages which are marked as unevictable are protected from compaction, but not from other types of migration. The POSIX real time extension explicitly states that mlock() will prevent a major page fault, but the spirit of is is that mlock() should give a process the ability to control

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Eric B Munson
On Fri, 13 Mar 2015, Rik van Riel wrote: On 03/13/2015 01:26 PM, Eric B Munson wrote: --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1046,6 +1046,8 @@ typedef enum { ISOLATE_SUCCESS,/* Pages isolated, migrate */ } isolate_migrate_t; +int

[PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Eric B Munson
Currently, pages which are marked as unevictable are protected from compaction, but not from other types of migration. The POSIX real time extension explicitly states that mlock() will prevent a major page fault, but the spirit of is is that mlock() should give a process the ability to control

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Rik van Riel
On 03/13/2015 01:26 PM, Eric B Munson wrote: --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1046,6 +1046,8 @@ typedef enum { ISOLATE_SUCCESS,/* Pages isolated, migrate */ } isolate_migrate_t; +int sysctl_compact_unevictable; + /* * Isolate all pages that can be

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Michal Hocko
On Fri 13-03-15 15:09:15, Eric B Munson wrote: On Fri, 13 Mar 2015, Rik van Riel wrote: On 03/13/2015 01:26 PM, Eric B Munson wrote: --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1046,6 +1046,8 @@ typedef enum { ISOLATE_SUCCESS,/* Pages isolated, migrate */ }

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Michal Hocko
On Fri 13-03-15 13:26:37, Eric B Munson wrote: [...] +compact_unevictable + +Available only when CONFIG_COMPACTION is set. When set to 1, compaction is +allowed to examine the unevictable lru (mlocked pages) for pages to compact. +This should be used on systems where stalls for minor page

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread David Rientjes
On Fri, 13 Mar 2015, Eric B Munson wrote: --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1046,6 +1046,8 @@ typedef enum { ISOLATE_SUCCESS,/* Pages isolated, migrate */ } isolate_migrate_t; +int sysctl_compact_unevictable; + /* * Isolate all pages

Re: [PATCH V5] Allow compaction of unevictable pages

2015-03-13 Thread Rik van Riel
On 03/13/2015 07:18 PM, David Rientjes wrote: On Fri, 13 Mar 2015, Eric B Munson wrote: --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1046,6 +1046,8 @@ typedef enum { ISOLATE_SUCCESS,/* Pages isolated, migrate */ } isolate_migrate_t; +int sysctl_compact_unevictable; +