Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-04-05 Thread Jayachandran C
Hi Bjorn, On Tue, Apr 5, 2016 at 10:11 PM, Bjorn Helgaas wrote: > > Hi Tomasz, > > On Tue, Apr 05, 2016 at 04:11:55PM +0200, Tomasz Nowicki wrote: > > On 09.03.2016 10:13, Tomasz Nowicki wrote: > > >Hi Bjorn, > > > > > >Thanks for your pointers! See my comments inline. Aslo, can you please > > >h

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-04-05 Thread Tomasz Nowicki
Hi Bjorn, On 05.04.2016 18:41, Bjorn Helgaas wrote: Hi Tomasz, [...] As you pointed out raw_pci_{read|write} make things complicated, so IMO we should either say they are absolutely necessary (and then think how to simplify it) or just use simple bus-specific accessor (patch 02/15) e.g.

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-04-05 Thread Bjorn Helgaas
Hi Tomasz, On Tue, Apr 05, 2016 at 04:11:55PM +0200, Tomasz Nowicki wrote: > On 09.03.2016 10:13, Tomasz Nowicki wrote: > >Hi Bjorn, > > > >Thanks for your pointers! See my comments inline. Aslo, can you please > >have a look at my previous patch set v4 and check how many of your > >comments are a

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-04-05 Thread Tomasz Nowicki
On 09.03.2016 10:13, Tomasz Nowicki wrote: Hi Bjorn, Thanks for your pointers! See my comments inline. Aslo, can you please have a look at my previous patch set v4 and check how many of your comments are already addressed there. We may want to back to it then. https://lkml.org/lkml/2016/2/4/646

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-10 Thread Jayachandran Chandrashekaran Nair
Hi Tomasz, On Wed, Mar 9, 2016 at 4:20 PM, Tomasz Nowicki wrote: > Hi Jayachandran, > > > On 09.03.2016 11:10, Jayachandran Chandrashekaran Nair wrote: >> >> Hi Tomasz, >> >> On Wed, Mar 9, 2016 at 2:43 PM, Tomasz Nowicki wrote: >>> >>> Hi Bjorn, >>> >>> Thanks for your pointers! See my comments

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-09 Thread Tomasz Nowicki
Hi Jayachandran, On 09.03.2016 11:10, Jayachandran Chandrashekaran Nair wrote: Hi Tomasz, On Wed, Mar 9, 2016 at 2:43 PM, Tomasz Nowicki wrote: Hi Bjorn, Thanks for your pointers! See my comments inline. Aslo, can you please have a look at my previous patch set v4 and check how many of your

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-09 Thread Jayachandran Chandrashekaran Nair
Hi Tomasz, On Wed, Mar 9, 2016 at 2:43 PM, Tomasz Nowicki wrote: > Hi Bjorn, > > Thanks for your pointers! See my comments inline. Aslo, can you please have > a look at my previous patch set v4 and check how many of your comments are > already addressed there. We may want to back to it then. > >

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-09 Thread Tomasz Nowicki
On 09.03.2016 10:13, Tomasz Nowicki wrote: So I think we should write generic MCFG and ECAM support from scratch for arm64. Something like this: - Add an acpi_mcfg_init(), maybe in drivers/acpi/pci_mcfg.c, to be called from acpi_init() to copy MCFG info to something we can access a

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-09 Thread Tomasz Nowicki
Hi Bjorn, Thanks for your pointers! See my comments inline. Aslo, can you please have a look at my previous patch set v4 and check how many of your comments are already addressed there. We may want to back to it then. https://lkml.org/lkml/2016/2/4/646 Especially patches [0-6] which handle MM

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-04 Thread Bjorn Helgaas
On Fri, Mar 04, 2016 at 02:05:56PM +0530, Jayachandran Chandrashekaran Nair wrote: > On Fri, Mar 4, 2016 at 4:21 AM, Bjorn Helgaas wrote: > > Hi Tomasz, Jayachandran, et al, > > > > On Tue, Feb 16, 2016 at 02:53:31PM +0100, Tomasz Nowicki wrote: > >> From: Jayachandran C > >> > >> Move pci_mmcfg

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-04 Thread Tomasz Nowicki
Hi Bjorn, On 03.03.2016 23:51, Bjorn Helgaas wrote: Hi Tomasz, Jayachandran, et al, On Tue, Feb 16, 2016 at 02:53:31PM +0100, Tomasz Nowicki wrote: From: Jayachandran C Move pci_mmcfg_list handling to a drivers/acpi/pci_mcfg.c. This is to share the API and code with ARM64 later. The correspo

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-04 Thread Jayachandran Chandrashekaran Nair
On Fri, Mar 4, 2016 at 4:21 AM, Bjorn Helgaas wrote: > Hi Tomasz, Jayachandran, et al, > > On Tue, Feb 16, 2016 at 02:53:31PM +0100, Tomasz Nowicki wrote: >> From: Jayachandran C >> >> Move pci_mmcfg_list handling to a drivers/acpi/pci_mcfg.c. This is >> to share the API and code with ARM64 later

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-03-03 Thread Bjorn Helgaas
Hi Tomasz, Jayachandran, et al, On Tue, Feb 16, 2016 at 02:53:31PM +0100, Tomasz Nowicki wrote: > From: Jayachandran C > > Move pci_mmcfg_list handling to a drivers/acpi/pci_mcfg.c. This is > to share the API and code with ARM64 later. The corresponding > declarations are moved from asm/pci_x86.

Re: [Linaro-acpi] [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-02-18 Thread Lorenzo Pieralisi
On Thu, Feb 18, 2016 at 08:25:35PM +0800, liudongdong (C) wrote: [...] > >+/* > >+ * Map a pci_mmcfg_region, can be overrriden by arch > >+ */ > >+int __weak pci_mmconfig_map_resource(struct device *dev, > >+struct pci_mmcfg_region *mcfg) > >+{ > >+struct resource *tmp; > >+void __iom

Re: [Linaro-acpi] [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-02-18 Thread liudongdong (C)
Hi Tomasz 在 2016/2/16 21:53, Tomasz Nowicki 写道: From: Jayachandran C Move pci_mmcfg_list handling to a drivers/acpi/pci_mcfg.c. This is to share the API and code with ARM64 later. The corresponding declarations are moved from asm/pci_x86.h to linux/pci-acpi.h As a part of this we introduce th

Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-02-17 Thread Lorenzo Pieralisi
On Tue, Feb 16, 2016 at 02:53:31PM +0100, Tomasz Nowicki wrote: > From: Jayachandran C > > Move pci_mmcfg_list handling to a drivers/acpi/pci_mcfg.c. This is > to share the API and code with ARM64 later. The corresponding > declarations are moved from asm/pci_x86.h to linux/pci-acpi.h > > As a p

[PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

2016-02-16 Thread Tomasz Nowicki
From: Jayachandran C Move pci_mmcfg_list handling to a drivers/acpi/pci_mcfg.c. This is to share the API and code with ARM64 later. The corresponding declarations are moved from asm/pci_x86.h to linux/pci-acpi.h As a part of this we introduce three functions that can be implemented by the arch c