Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-11 Thread Liang, Kan
On 4/11/2019 5:00 AM, Peter Zijlstra wrote: On Wed, Apr 10, 2019 at 09:47:20PM +0200, Peter Zijlstra wrote: Sure, those are actually forced 0 with the existing thing. I'll go fold smething like back in. Thanks! @@ -3472,7 +3475,7 @@ icl_get_event_constraints(struct cpu_hw_events *cpuc,

Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-11 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 09:47:20PM +0200, Peter Zijlstra wrote: > Sure, those are actually forced 0 with the existing thing. > > I'll go fold smething like back in. Thanks! > > @@ -3472,7 +3475,7 @@ icl_get_event_constraints(struct cpu_hw_events *cpuc, > > int idx, > > * Force

Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-10 Thread Peter Zijlstra
On Wed, Apr 10, 2019 at 02:22:21PM -0400, Liang, Kan wrote: > > > That is, are there really bits we want to mask in there? > > > > For instruction event, right, we don't need mask it. > > I will change it. > > > > Actually, we have to mask some bits here, e.g. ARCH_PERFMON_EVENTSEL_INT, >

Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-10 Thread Liang, Kan
On 4/8/2019 11:45 AM, Liang, Kan wrote: On 4/8/2019 11:06 AM, Peter Zijlstra wrote: On Tue, Apr 02, 2019 at 12:45:05PM -0700, kan.li...@linux.intel.com wrote: +static struct event_constraint * +icl_get_event_constraints(struct cpu_hw_events *cpuc, int idx, +  struct perf_event

Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-08 Thread Liang, Kan
On 4/8/2019 11:06 AM, Peter Zijlstra wrote: On Tue, Apr 02, 2019 at 12:45:05PM -0700, kan.li...@linux.intel.com wrote: +static struct event_constraint * +icl_get_event_constraints(struct cpu_hw_events *cpuc, int idx, + struct perf_event *event) +{ + /* +

Re: [PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-08 Thread Peter Zijlstra
On Tue, Apr 02, 2019 at 12:45:05PM -0700, kan.li...@linux.intel.com wrote: > +static struct event_constraint * > +icl_get_event_constraints(struct cpu_hw_events *cpuc, int idx, > + struct perf_event *event) > +{ > + /* > + * Fixed counter 0 has less skid. > + *

[PATCH V5 08/12] perf/x86/intel: Add Icelake support

2019-04-02 Thread kan . liang
From: Kan Liang Add Icelake core PMU perf code, including constraint tables and the main enable code. Icelake expanded the generic counters to always 8 even with HT on, but a range of events cannot be scheduled on the extra 4 counters. Add new constraint ranges to describe this to the