Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-03-09 Thread Viresh Kumar
On 09-03-21, 15:11, Ionela Voinescu wrote: > On Monday 01 Mar 2021 at 12:21:17 (+0530), Viresh Kumar wrote: > > diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h > > index 0f6cd6b73a61..3bcfba5c21a7 100644 > > --- a/include/linux/arch_topology.h > > +++ b/include/linux/arch

Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-03-09 Thread Ionela Voinescu
On Monday 01 Mar 2021 at 12:21:17 (+0530), Viresh Kumar wrote: > This patch attempts to make it generic enough so other parts of the > kernel can also provide their own implementation of scale_freq_tick() > callback, which is called by the scheduler periodically to update the > per-cpu freq_scale v

Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-03-09 Thread Will Deacon
On Tue, Mar 09, 2021 at 09:46:43AM +0530, Viresh Kumar wrote: > On 08-03-21, 14:52, Will Deacon wrote: > > On Mon, Mar 01, 2021 at 12:21:17PM +0530, Viresh Kumar wrote: > > > +EXPORT_SYMBOL_GPL(topology_set_scale_freq_source); > > > > I don't get why you need to export this in this patch. The arm6

Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-03-08 Thread Viresh Kumar
On 08-03-21, 14:52, Will Deacon wrote: > On Mon, Mar 01, 2021 at 12:21:17PM +0530, Viresh Kumar wrote: > > +EXPORT_SYMBOL_GPL(topology_set_scale_freq_source); > > I don't get why you need to export this in this patch. The arm64 topology > code is never built as a module. > > > +EXPORT_SYMBOL_GPL(

Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-03-08 Thread Will Deacon
On Mon, Mar 01, 2021 at 12:21:17PM +0530, Viresh Kumar wrote: > This patch attempts to make it generic enough so other parts of the > kernel can also provide their own implementation of scale_freq_tick() > callback, which is called by the scheduler periodically to update the > per-cpu freq_scale va

[PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback

2021-02-28 Thread Viresh Kumar
This patch attempts to make it generic enough so other parts of the kernel can also provide their own implementation of scale_freq_tick() callback, which is called by the scheduler periodically to update the per-cpu freq_scale variable. The implementations now need to provide 'struct scale_freq_da