Re: [PATCH V5 1/4] soc: brcmstb: Add Product ID and Family ID helper functions

2017-09-21 Thread Joe Perches
On Thu, 2017-09-21 at 15:16 -0400, Al Cooper wrote: > Kishon, > > I ran checkpatch on all my patches before submitting them and didn't > get any warnings. It looks like you may be running checkpatch with the > "--subjective" option. Is this a requirement and if so are there any > other checkpatch

Re: [PATCH V5 1/4] soc: brcmstb: Add Product ID and Family ID helper functions

2017-09-21 Thread Al Cooper
Kishon, I ran checkpatch on all my patches before submitting them and didn't get any warnings. It looks like you may be running checkpatch with the "--subjective" option. Is this a requirement and if so are there any other checkpatch options I should be using? Thanks Al On Thu, Sep 21, 2017 at 4

Re: [PATCH V5 1/4] soc: brcmstb: Add Product ID and Family ID helper functions

2017-09-21 Thread Kishon Vijay Abraham I
Hi, On Saturday 02 September 2017 07:45 AM, Florian Fainelli wrote: > > > On 08/25/2017 10:51 AM, Al Cooper wrote: >> Signed-off-by: Al Cooper > > Acked-by: Florian Fainelli I get the following checkpatch warning CHECK: Macro argument reuse 'reg' - possible side-effects? #110: FILE: include/

Re: [PATCH V5 1/4] soc: brcmstb: Add Product ID and Family ID helper functions

2017-09-01 Thread Florian Fainelli
On 08/25/2017 10:51 AM, Al Cooper wrote: > Signed-off-by: Al Cooper Acked-by: Florian Fainelli > --- > drivers/soc/bcm/brcmstb/common.c| 12 > include/linux/soc/brcmstb/brcmstb.h | 10 ++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/soc/bcm/brcmstb/c

[PATCH V5 1/4] soc: brcmstb: Add Product ID and Family ID helper functions

2017-08-25 Thread Al Cooper
Signed-off-by: Al Cooper --- drivers/soc/bcm/brcmstb/common.c| 12 include/linux/soc/brcmstb/brcmstb.h | 10 ++ 2 files changed, 22 insertions(+) diff --git a/drivers/soc/bcm/brcmstb/common.c b/drivers/soc/bcm/brcmstb/common.c index b6195fd..184dbf5 100644 --- a/drivers/