Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-06 Thread Bartosz Szczepanek
Nope, it doesn't work. It compiled (after correcting one more leftover mapping), but panicked the same way. I've came up with a set of changes that make it working in my setup, see attached patch. There was a problem with passing already remapped address to tpm2_calc_event_log_size(), which tried

Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-02 Thread Ingo Molnar
* Matthew Garrett wrote: > On Thu, May 2, 2019 at 12:15 AM Ard Biesheuvel > wrote: > > > > (+ Ingo) > > > > On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > > > > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek > > > wrote: > > > > > > > > I may be a little late with this comme

Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-02 Thread Ard Biesheuvel
On Thu, 2 May 2019 at 20:04, Matthew Garrett wrote: > > On Thu, May 2, 2019 at 12:15 AM Ard Biesheuvel > wrote: > > > > (+ Ingo) > > > > On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > > > > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek > > > wrote: > > > > > > > > I may be a l

Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-02 Thread Ard Biesheuvel
(+ Ingo) On Tue, 30 Apr 2019 at 21:52, Matthew Garrett wrote: > > On Tue, Apr 30, 2019 at 6:07 AM Bartosz Szczepanek wrote: > > > > I may be a little late with this comment, but I've just tested these > > patches on aarch64 platform (from the top of jjs/master) and got > > kernel panic ("Unable

Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-01 Thread Bartosz Szczepanek
Second patch tries to unmap "mapping" which is not declared. I'm on top of jjs/master and your TPM_MEMREMAP patches are already there, so the first patch applied cleanly. Using it, kernel still panicked on boot: EFI stub: Booting Linux Kernel... EFI stub: EFI_RNG_PROTOCOL unavailable, no randomnes

[PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-02-27 Thread Matthew Garrett
From: Matthew Garrett UEFI systems provide a boot services protocol for obtaining the TPM event log, but this is unusable after ExitBootServices() is called. Unfortunately ExitBootServices() itself triggers additional TPM events that then can't be obtained using this protocol. The platform provid