Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-05-03 Thread Arnd Bergmann
On Tuesday 03 May 2016 11:11:56 Rob Herring wrote: > > + > > +Child nodes: > > +Every SLIMbus controller node can contain zero or more child nodes > > +representing slave devices on the bus. Every SLIMbus slave device is > > +uniquely determined by the enumeration address containing 4 fields: > >

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-05-03 Thread Arnd Bergmann
On Tuesday 03 May 2016 11:11:56 Rob Herring wrote: > > + > > +Child nodes: > > +Every SLIMbus controller node can contain zero or more child nodes > > +representing slave devices on the bus. Every SLIMbus slave device is > > +uniquely determined by the enumeration address containing 4 fields: > >

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-05-03 Thread Rob Herring
On Wed, Apr 27, 2016 at 05:58:05PM -0600, Sagar Dharia wrote: > OF helper routine scans the SLIMbus DeviceTree, allocates resources, > and creates slim_devices according to the hierarchy. > > Signed-off-by: Sagar Dharia > --- >

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-05-03 Thread Rob Herring
On Wed, Apr 27, 2016 at 05:58:05PM -0600, Sagar Dharia wrote: > OF helper routine scans the SLIMbus DeviceTree, allocates resources, > and creates slim_devices according to the hierarchy. > > Signed-off-by: Sagar Dharia > --- > Documentation/devicetree/bindings/slimbus/bus.txt | 55

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-04-28 Thread Mark Rutland
On Wed, Apr 27, 2016 at 05:58:05PM -0600, Sagar Dharia wrote: > OF helper routine scans the SLIMbus DeviceTree, allocates resources, > and creates slim_devices according to the hierarchy. > > Signed-off-by: Sagar Dharia > --- >

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-04-28 Thread Mark Rutland
On Wed, Apr 27, 2016 at 05:58:05PM -0600, Sagar Dharia wrote: > OF helper routine scans the SLIMbus DeviceTree, allocates resources, > and creates slim_devices according to the hierarchy. > > Signed-off-by: Sagar Dharia > --- > Documentation/devicetree/bindings/slimbus/bus.txt | 55

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-04-28 Thread Arnd Bergmann
On Wednesday 27 April 2016 17:58:05 Sagar Dharia wrote: > +#if IS_ENABLED(CONFIG_OF) > +/* OF helpers for SLIMbus */ > +static void of_register_slim_devices(struct slim_controller *ctrl) > +{ > + struct device_node *node; > The #ifdef seems useless here, what kind of system would not have

Re: [PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-04-28 Thread Arnd Bergmann
On Wednesday 27 April 2016 17:58:05 Sagar Dharia wrote: > +#if IS_ENABLED(CONFIG_OF) > +/* OF helpers for SLIMbus */ > +static void of_register_slim_devices(struct slim_controller *ctrl) > +{ > + struct device_node *node; > The #ifdef seems useless here, what kind of system would not have

[PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-04-27 Thread Sagar Dharia
OF helper routine scans the SLIMbus DeviceTree, allocates resources, and creates slim_devices according to the hierarchy. Signed-off-by: Sagar Dharia --- Documentation/devicetree/bindings/slimbus/bus.txt | 55 ++ drivers/slimbus/slim-core.c

[PATCH V5 2/6] of/slimbus: OF helper for SLIMbus

2016-04-27 Thread Sagar Dharia
OF helper routine scans the SLIMbus DeviceTree, allocates resources, and creates slim_devices according to the hierarchy. Signed-off-by: Sagar Dharia --- Documentation/devicetree/bindings/slimbus/bus.txt | 55 ++ drivers/slimbus/slim-core.c | 57