Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-12 Thread Changsheng Liu
在 2015/10/12 9:45, Tang Chen 写道: Hi Ishimatsu, On 10/10/2015 02:13 AM, Yasuaki Ishimatsu wrote: Hi Tang, On Fri, 9 Oct 2015 15:59:38 +0800 Tang Chen wrote: Hi, I don't mean to offend, but I really think it is not necessary to do this. hot-added memory will be added to ZONE_NORMAL by

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-12 Thread Changsheng Liu
在 2015/10/12 9:45, Tang Chen 写道: Hi Ishimatsu, On 10/10/2015 02:13 AM, Yasuaki Ishimatsu wrote: Hi Tang, On Fri, 9 Oct 2015 15:59:38 +0800 Tang Chen wrote: Hi, I don't mean to offend, but I really think it is not necessary to do this. hot-added memory will be

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-11 Thread Tang Chen
Hi Ishimatsu, On 10/10/2015 02:13 AM, Yasuaki Ishimatsu wrote: Hi Tang, On Fri, 9 Oct 2015 15:59:38 +0800 Tang Chen wrote: Hi, I don't mean to offend, but I really think it is not necessary to do this. hot-added memory will be added to ZONE_NORMAL by default. You can modify it when you

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-11 Thread Tang Chen
Hi Ishimatsu, On 10/10/2015 02:13 AM, Yasuaki Ishimatsu wrote: Hi Tang, On Fri, 9 Oct 2015 15:59:38 +0800 Tang Chen wrote: Hi, I don't mean to offend, but I really think it is not necessary to do this. hot-added memory will be added to ZONE_NORMAL by default. You

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-10 Thread Hillf Danton
> > From: Changsheng Liu > > After the user config CONFIG_MOVABLE_NODE, > When the memory is hot added, should_add_memory_movable() return 0 > because all zones including movable zone are empty, > so the memory that was hot added will be added to the normal zone > and the normal zone will be

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-10 Thread Hillf Danton
> > From: Changsheng Liu > > After the user config CONFIG_MOVABLE_NODE, > When the memory is hot added, should_add_memory_movable() return 0 > because all zones including movable zone are empty, > so the memory that was hot added will be added to the normal zone > and

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread kbuild test robot
Hi Changsheng, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-s1-10100137 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >>

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Yasuaki Ishimatsu
Hi Tang, On Fri, 9 Oct 2015 15:59:38 +0800 Tang Chen wrote: > Hi, > > I don't mean to offend, but I really think it is not necessary to do this. > > hot-added memory will be added to ZONE_NORMAL by default. You can > modify it when you online memory. I think it is enough for users. But we

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Tang Chen
Hi, I don't mean to offend, but I really think it is not necessary to do this. hot-added memory will be added to ZONE_NORMAL by default. You can modify it when you online memory. I think it is enough for users. And a sysctl interface is also unnecessary. I think one default behaviour is enough

[PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Changsheng Liu
From: Changsheng Liu After the user config CONFIG_MOVABLE_NODE, When the memory is hot added, should_add_memory_movable() return 0 because all zones including movable zone are empty, so the memory that was hot added will be added to the normal zone and the normal zone will be created firstly.

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Tang Chen
Hi, I don't mean to offend, but I really think it is not necessary to do this. hot-added memory will be added to ZONE_NORMAL by default. You can modify it when you online memory. I think it is enough for users. And a sysctl interface is also unnecessary. I think one default behaviour is enough

[PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Changsheng Liu
From: Changsheng Liu After the user config CONFIG_MOVABLE_NODE, When the memory is hot added, should_add_memory_movable() return 0 because all zones including movable zone are empty, so the memory that was hot added will be added to the normal zone and the normal zone

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread Yasuaki Ishimatsu
Hi Tang, On Fri, 9 Oct 2015 15:59:38 +0800 Tang Chen wrote: > Hi, > > I don't mean to offend, but I really think it is not necessary to do this. > > hot-added memory will be added to ZONE_NORMAL by default. You can > modify it when you online memory. I think it is

Re: [PATCH V6] mm: memory hot-add: memory can not be added to movable zone defaultly

2015-10-09 Thread kbuild test robot
Hi Changsheng, [auto build test ERROR on v4.3-rc4 -- if it's inappropriate base, please ignore] config: x86_64-randconfig-s1-10100137 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >>