Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 9:53 AM, Thomas Gleixner wrote: > On Tue, 19 Jun 2018, Reinette Chatre wrote: >> On 6/19/2018 5:31 AM, Thomas Gleixner wrote: >>> On Thu, 7 Jun 2018, Reinette Chatre wrote: +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r) +{ + unsigned long

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 9:53 AM, Thomas Gleixner wrote: > On Tue, 19 Jun 2018, Reinette Chatre wrote: >> On 6/19/2018 5:31 AM, Thomas Gleixner wrote: >>> On Thu, 7 Jun 2018, Reinette Chatre wrote: +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r) +{ + unsigned long

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Thomas Gleixner
On Tue, 19 Jun 2018, Reinette Chatre wrote: > On 6/19/2018 5:31 AM, Thomas Gleixner wrote: > > On Thu, 7 Jun 2018, Reinette Chatre wrote: > >> +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r) > >> +{ > >> + unsigned long *val = (unsigned long *)_val; > > > > I'm a bit worried

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Thomas Gleixner
On Tue, 19 Jun 2018, Reinette Chatre wrote: > On 6/19/2018 5:31 AM, Thomas Gleixner wrote: > > On Thu, 7 Jun 2018, Reinette Chatre wrote: > >> +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r) > >> +{ > >> + unsigned long *val = (unsigned long *)_val; > > > > I'm a bit worried

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 5:31 AM, Thomas Gleixner wrote: > On Thu, 7 Jun 2018, Reinette Chatre wrote: >> +/** >> + * cbm_ensure_valid - Enforce validity on provided CBM >> + * @_val: Candidate CBM >> + * @r: RDT resource to which the CBM belongs >> + * >> + * The provided CBM

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 5:31 AM, Thomas Gleixner wrote: > On Thu, 7 Jun 2018, Reinette Chatre wrote: >> +/** >> + * cbm_ensure_valid - Enforce validity on provided CBM >> + * @_val: Candidate CBM >> + * @r: RDT resource to which the CBM belongs >> + * >> + * The provided CBM

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Thomas Gleixner
On Thu, 7 Jun 2018, Reinette Chatre wrote: > +/** > + * cbm_ensure_valid - Enforce validity on provided CBM > + * @_val:Candidate CBM > + * @r: RDT resource to which the CBM belongs > + * > + * The provided CBM represents all cache portions available for use. This > + * may be

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Thomas Gleixner
On Thu, 7 Jun 2018, Reinette Chatre wrote: > +/** > + * cbm_ensure_valid - Enforce validity on provided CBM > + * @_val:Candidate CBM > + * @r: RDT resource to which the CBM belongs > + * > + * The provided CBM represents all cache portions available for use. This > + * may be

[PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-07 Thread Reinette Chatre
Currently when a new resource group is created its allocations would be those that belonged to the resource group to which its closid belonged previously. That is, we can encounter a case like: mkdir newgroup cat newgroup/schemata L2:0=ff;1=ff echo 'L2:0=0xf0;1=0xf0' > newgroup/schemata cat

[PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-07 Thread Reinette Chatre
Currently when a new resource group is created its allocations would be those that belonged to the resource group to which its closid belonged previously. That is, we can encounter a case like: mkdir newgroup cat newgroup/schemata L2:0=ff;1=ff echo 'L2:0=0xf0;1=0xf0' > newgroup/schemata cat