Re: [PATCH V6 20/33] csky/dma: fix up dma_mapping error

2018-09-30 Thread Guo Ren
On Sat, Sep 29, 2018 at 11:08:41PM +0800, Guo Ren wrote: > On Fri, Sep 28, 2018 at 09:21:16AM -0700, Christoph Hellwig wrote: > > On Fri, Sep 28, 2018 at 08:51:17AM +0800, Guo Ren wrote: > > > The arch_sync_dma_for_cpu()/arch_sync_dma_for_device() implementation is > > > broken for some combination

Re: [PATCH V6 20/33] csky/dma: fix up dma_mapping error

2018-09-29 Thread Guo Ren
On Fri, Sep 28, 2018 at 09:21:16AM -0700, Christoph Hellwig wrote: > On Fri, Sep 28, 2018 at 08:51:17AM +0800, Guo Ren wrote: > > The arch_sync_dma_for_cpu()/arch_sync_dma_for_device() implementation is > > broken for some combinations that end up in a BUG() instead of performing > > the necessary

Re: [PATCH V6 20/33] csky/dma: fix up dma_mapping error

2018-09-28 Thread Christoph Hellwig
On Fri, Sep 28, 2018 at 08:51:17AM +0800, Guo Ren wrote: > The arch_sync_dma_for_cpu()/arch_sync_dma_for_device() implementation is > broken for some combinations that end up in a BUG() instead of performing > the necessary flushes. This should be folded into the original patch adding this code.

[PATCH V6 20/33] csky/dma: fix up dma_mapping error

2018-09-27 Thread Guo Ren
The arch_sync_dma_for_cpu()/arch_sync_dma_for_device() implementation is broken for some combinations that end up in a BUG() instead of performing the necessary flushes. The implementation of arch should follow the following rules: map for_cpu for_device unmap TO