Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Paul Moore
On Friday, July 17, 2015 12:48:53 PM Richard Guy Briggs wrote: > On 15/07/16, Paul Moore wrote: > > On Thursday, July 16, 2015 10:01:30 PM Eric Paris wrote: > > > I have to admit, I'm partial to not merging this (with the other > > > patches). Changing object lifetimes in what i seem to remember

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Paul Moore
On Friday, July 17, 2015 12:18:27 PM Richard Guy Briggs wrote: > On 15/07/16, Eric Paris wrote: > > I have to admit, I'm partial to not merging this (with the other > > patches). Changing object lifetimes in what i seem to remember is long > > standing code (auditfilter, not auditexe) seems to me

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Richard Guy Briggs
On 15/07/16, Paul Moore wrote: > On Thursday, July 16, 2015 10:01:30 PM Eric Paris wrote: > > I have to admit, I'm partial to not merging this (with the other > > patches). Changing object lifetimes in what i seem to remember is long > > standing code (auditfilter, not auditexe) seems to me like

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Richard Guy Briggs
On 15/07/16, Eric Paris wrote: > I have to admit, I'm partial to not merging this (with the other > patches). Changing object lifetimes in what i seem to remember is long > standing code (auditfilter, not auditexe) seems to me like something we > really would want to be git bisectable, not mushed

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Richard Guy Briggs
On 15/07/16, Eric Paris wrote: I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long standing code (auditfilter, not auditexe) seems to me like something we really would want to be git bisectable, not mushed

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Richard Guy Briggs
On 15/07/16, Paul Moore wrote: On Thursday, July 16, 2015 10:01:30 PM Eric Paris wrote: I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long standing code (auditfilter, not auditexe) seems to me like

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Paul Moore
On Friday, July 17, 2015 12:48:53 PM Richard Guy Briggs wrote: On 15/07/16, Paul Moore wrote: On Thursday, July 16, 2015 10:01:30 PM Eric Paris wrote: I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-17 Thread Paul Moore
On Friday, July 17, 2015 12:18:27 PM Richard Guy Briggs wrote: On 15/07/16, Eric Paris wrote: I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long standing code (auditfilter, not auditexe) seems to me like

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Paul Moore
On Thursday, July 16, 2015 10:01:30 PM Eric Paris wrote: > I have to admit, I'm partial to not merging this (with the other > patches). Changing object lifetimes in what i seem to remember is long > standing code (auditfilter, not auditexe) seems to me like something we > really would want to be

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Eric Paris
I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long standing code (auditfilter, not auditexe) seems to me like something we really would want to be git bisectable, not mushed with an unrelated feature addition.

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Paul Moore
On Thursday, July 16, 2015 10:01:28 PM Richard Guy Briggs wrote: > On 15/07/16, Paul Moore wrote: > > On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote: > > > Make this interface consistent with watch and filter key, avoiding the > > > extra string copy and simply consume the new

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Richard Guy Briggs
On 15/07/16, Paul Moore wrote: > On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote: > > Make this interface consistent with watch and filter key, avoiding the extra > > string copy and simply consume the new string pointer. > > > > Signed-off-by: Richard Guy Briggs > > --- > >

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Paul Moore
On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote: > Make this interface consistent with watch and filter key, avoiding the extra > string copy and simply consume the new string pointer. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit_exe.c |8 ++-- >

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Paul Moore
On Thursday, July 16, 2015 10:01:30 PM Eric Paris wrote: I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long standing code (auditfilter, not auditexe) seems to me like something we really would want to be git

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Eric Paris
I have to admit, I'm partial to not merging this (with the other patches). Changing object lifetimes in what i seem to remember is long standing code (auditfilter, not auditexe) seems to me like something we really would want to be git bisectable, not mushed with an unrelated feature addition.

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Paul Moore
On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote: Make this interface consistent with watch and filter key, avoiding the extra string copy and simply consume the new string pointer. Signed-off-by: Richard Guy Briggs r...@redhat.com --- kernel/audit_exe.c |8 ++--

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Paul Moore
On Thursday, July 16, 2015 10:01:28 PM Richard Guy Briggs wrote: On 15/07/16, Paul Moore wrote: On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote: Make this interface consistent with watch and filter key, avoiding the extra string copy and simply consume the new string

Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-16 Thread Richard Guy Briggs
On 15/07/16, Paul Moore wrote: On Tuesday, July 14, 2015 11:50:26 AM Richard Guy Briggs wrote: Make this interface consistent with watch and filter key, avoiding the extra string copy and simply consume the new string pointer. Signed-off-by: Richard Guy Briggs r...@redhat.com ---

[PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-14 Thread Richard Guy Briggs
Make this interface consistent with watch and filter key, avoiding the extra string copy and simply consume the new string pointer. Signed-off-by: Richard Guy Briggs --- kernel/audit_exe.c |8 ++-- kernel/audit_fsnotify.c |9 + kernel/auditfilter.c|2 +- 3 files

[PATCH V6 4/4] audit: avoid double copying the audit_exe path string

2015-07-14 Thread Richard Guy Briggs
Make this interface consistent with watch and filter key, avoiding the extra string copy and simply consume the new string pointer. Signed-off-by: Richard Guy Briggs r...@redhat.com --- kernel/audit_exe.c |8 ++-- kernel/audit_fsnotify.c |9 + kernel/auditfilter.c|