Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Viresh Kumar
On 18-06-18, 13:28, Daniel Lezcano wrote: > for this specific case, we can use the park() callback to set should_run > to false, no ? Yep, that can be one option. Or just iterate through all the CPUs in the mask. -- viresh

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Viresh Kumar
On 18-06-18, 13:28, Daniel Lezcano wrote: > for this specific case, we can use the park() callback to set should_run > to false, no ? Yep, that can be one option. Or just iterate through all the CPUs in the mask. -- viresh

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Daniel Lezcano
On 18/06/2018 12:38, Viresh Kumar wrote: > On 18-06-18, 12:35, Daniel Lezcano wrote: >> On 18/06/2018 12:22, Viresh Kumar wrote: >>> On 15-06-18, 11:19, Daniel Lezcano wrote: +/** + * idle_injection_stop - stops the idle injections + * @ii_dev: a pointer to an idle injection_device

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Daniel Lezcano
On 18/06/2018 12:38, Viresh Kumar wrote: > On 18-06-18, 12:35, Daniel Lezcano wrote: >> On 18/06/2018 12:22, Viresh Kumar wrote: >>> On 15-06-18, 11:19, Daniel Lezcano wrote: +/** + * idle_injection_stop - stops the idle injections + * @ii_dev: a pointer to an idle injection_device

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Viresh Kumar
On 18-06-18, 12:35, Daniel Lezcano wrote: > On 18/06/2018 12:22, Viresh Kumar wrote: > > On 15-06-18, 11:19, Daniel Lezcano wrote: > >> +/** > >> + * idle_injection_stop - stops the idle injections > >> + * @ii_dev: a pointer to an idle injection_device structure > >> + * > >> + * The function

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Viresh Kumar
On 18-06-18, 12:35, Daniel Lezcano wrote: > On 18/06/2018 12:22, Viresh Kumar wrote: > > On 15-06-18, 11:19, Daniel Lezcano wrote: > >> +/** > >> + * idle_injection_stop - stops the idle injections > >> + * @ii_dev: a pointer to an idle injection_device structure > >> + * > >> + * The function

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Daniel Lezcano
On 18/06/2018 12:22, Viresh Kumar wrote: > On 15-06-18, 11:19, Daniel Lezcano wrote: >> +/** >> + * idle_injection_stop - stops the idle injections >> + * @ii_dev: a pointer to an idle injection_device structure >> + * >> + * The function stops the idle injection and waits for the threads to >> +

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Daniel Lezcano
On 18/06/2018 12:22, Viresh Kumar wrote: > On 15-06-18, 11:19, Daniel Lezcano wrote: >> +/** >> + * idle_injection_stop - stops the idle injections >> + * @ii_dev: a pointer to an idle injection_device structure >> + * >> + * The function stops the idle injection and waits for the threads to >> +

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Viresh Kumar
On 15-06-18, 11:19, Daniel Lezcano wrote: > +/** > + * idle_injection_stop - stops the idle injections > + * @ii_dev: a pointer to an idle injection_device structure > + * > + * The function stops the idle injection and waits for the threads to > + * complete. If we are in the process of injecting

Re: [PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-18 Thread Viresh Kumar
On 15-06-18, 11:19, Daniel Lezcano wrote: > +/** > + * idle_injection_stop - stops the idle injections > + * @ii_dev: a pointer to an idle injection_device structure > + * > + * The function stops the idle injection and waits for the threads to > + * complete. If we are in the process of injecting

[PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-15 Thread Daniel Lezcano
Initially, the cpu_cooling device for ARM was changed by adding a new policy inserting idle cycles. The intel_powerclamp driver does a similar action. Instead of implementing idle injections privately in the cpu_cooling device, move the idle injection code in a dedicated framework and give the

[PATCH V7] powercap/drivers/idle_injection: Add an idle injection framework

2018-06-15 Thread Daniel Lezcano
Initially, the cpu_cooling device for ARM was changed by adding a new policy inserting idle cycles. The intel_powerclamp driver does a similar action. Instead of implementing idle injections privately in the cpu_cooling device, move the idle injection code in a dedicated framework and give the