Re: [PATCH V7 00/18] blk-throttle: add .low limit

2017-03-27 Thread Jens Axboe
On 03/27/2017 01:00 PM, Shaohua Li wrote: > On Mon, Mar 27, 2017 at 12:15:29PM -0600, Jens Axboe wrote: >> On 03/27/2017 11:51 AM, Shaohua Li wrote: >>> V6->V7: >>> - Don't overload blk stat, which will simplify the code. This will add extra >>> space in bio/request though with the low interface

Re: [PATCH V7 00/18] blk-throttle: add .low limit

2017-03-27 Thread Shaohua Li
On Mon, Mar 27, 2017 at 12:15:29PM -0600, Jens Axboe wrote: > On 03/27/2017 11:51 AM, Shaohua Li wrote: > > V6->V7: > > - Don't overload blk stat, which will simplify the code. This will add extra > > space in bio/request though with the low interface configure option on. > > Hmm, why? As far as

[PATCH V7 00/18] blk-throttle: add .low limit

2017-03-27 Thread Shaohua Li
Hi, cgroup still lacks a good iocontroller. CFQ works well for hard disk, but not much for SSD. This patch set try to add a conservative limit for blk-throttle. It isn't a proportional scheduling, but can help prioritize cgroups. There are several advantages we choose blk-throttle: - blk-throttle

Re: [PATCH V7 00/18] blk-throttle: add .low limit

2017-03-27 Thread Jens Axboe
On 03/27/2017 11:51 AM, Shaohua Li wrote: > V6->V7: > - Don't overload blk stat, which will simplify the code. This will add extra > space in bio/request though with the low interface configure option on. Hmm, why? As far as I can see, it just makes things worse. -- Jens Axboe